From owner-svn-src-all@FreeBSD.ORG Sat Aug 21 16:42:50 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E2F41065694; Sat, 21 Aug 2010 16:42:50 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from mail.mahoroba.org (ent.mahoroba.org [IPv6:2001:2f0:104:8010::1]) by mx1.freebsd.org (Postfix) with ESMTP id 250DD8FC08; Sat, 21 Aug 2010 16:42:49 +0000 (UTC) Received: from yuga.mahoroba.org (ume@yuga-m.mahoroba.org [IPv6:2001:2f0:104:801c:21b:d3ff:fe38:5381]) (user=ume mech=DIGEST-MD5 bits=0) by mail.mahoroba.org (8.14.4/8.14.4) with ESMTP/inet6 id o7LGgdm6080387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 Aug 2010 01:42:40 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sun, 22 Aug 2010 01:42:38 +0900 Message-ID: From: Hajimu UMEMOTO To: pluknet In-Reply-To: References: <201008201752.o7KHqnu1044143@svn.freebsd.org> User-Agent: xcite1.58> Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/23.2 (i386-portbld-freebsd8.1) MULE/6.0 (HANACHIRUSATO) X-Operating-System: FreeBSD 8.1-STABLE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (mail.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Sun, 22 Aug 2010 01:42:41 +0900 (JST) X-Virus-Scanned: clamav-milter 0.96.2 at asuka.mahoroba.org X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on asuka.mahoroba.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211530 - head/sys/netinet6 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2010 16:42:50 -0000 Hi, >>>>> On Fri, 20 Aug 2010 22:19:37 +0400 >>>>> pluknet said: pluknet> I think it still continues to test the remain condition pluknet> regardless of test result of the first part (!optp). No, I don't think my fix is wrong. If the evaluation matches, the latter should not be evaluated. pluknet> That should work: pluknet> - if (!optp->ip6po_pktinfo || !optp->ip6po_pktinfo->ipi6_ifindex) pluknet> + if (optp != NULL && (!optp->ip6po_pktinfo || pluknet> + !optp->ip6po_pktinfo->ipi6_ifindex)) With your proposal, when optp is NULL, use_defzone doesn't set. It is not desired thing. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/