From owner-freebsd-emulation@FreeBSD.ORG Wed May 9 15:37:36 2007 Return-Path: X-Original-To: emulation@freebsd.org Delivered-To: freebsd-emulation@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 81F0316A405 for ; Wed, 9 May 2007 15:37:36 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.249]) by mx1.freebsd.org (Postfix) with ESMTP id 3A33713C459 for ; Wed, 9 May 2007 15:37:36 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: by an-out-0708.google.com with SMTP id d23so52662and for ; Wed, 09 May 2007 08:37:35 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=Xv6iqdDbk1gaEU8pMamavSet0DjFsi2UVYZIRm7yGthUxPpAIJC6I9kajfqErt9i0tZktehNJUY+yWY2Wlio5nslle9USbDVV5mw8HrqI8RW22B2TbA1L5JgjqBjO1lxPg2viUSIk4QJxPOWP6r5giwwwk1cmhATKz49xAoT7jA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=B7wR7HNFTlOK/ZrDJcb39rYZGNgbuSKab5GGbLD8cQSVaJ1oZ/q65VMaalQsXhU03MpCMosTHZwxUmWOSmhMoR+OInk32eWLIuDRCqggwfppCB8y3ztFTL/tsI1L7sUTbtkcc3aJRfMyno7jgb2TaiVAsa6/Gghg3GHGN1YNfXc= Received: by 10.101.71.16 with SMTP id y16mr436077ank.1178725054296; Wed, 09 May 2007 08:37:34 -0700 (PDT) Received: by 10.100.139.10 with HTTP; Wed, 9 May 2007 08:37:34 -0700 (PDT) Message-ID: <790a9fff0705090837x3fe2ae7t15d5ceec21a39f40@mail.gmail.com> Date: Wed, 9 May 2007 10:37:34 -0500 From: "Scot Hetzel" To: "Bruce Evans" In-Reply-To: <20070509223211.O6076@delplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_117604_11761428.1178725054190" References: <790a9fff0705021345j2ad9ae98o56aaf357d556fe27@mail.gmail.com> <790a9fff0705040004oab16ed8q1a1c476386379ea9@mail.gmail.com> <20070504190007.Y37951@besplex.bde.org> <790a9fff0705040819u24e4c2f0s5c9fc34b93770e13@mail.gmail.com> <790a9fff0705061005v1a1a883ehc155bac7f747c3eb@mail.gmail.com> <20070507124848.S47783@besplex.bde.org> <790a9fff0705080724o1039c405g1cfa1b31ba6a91be@mail.gmail.com> <20070509223211.O6076@delplex.bde.org> Cc: emulation@freebsd.org, Pawel Jakub Dawidek Subject: Re: linuxolator: LTP lseek03 failure X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 15:37:36 -0000 ------=_Part_117604_11761428.1178725054190 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 5/9/07, Bruce Evans wrote: > On Tue, 8 May 2007, Scot Hetzel wrote: > > On 5/6/07, Bruce Evans wrote: > > I then created a patch to kern/vfs_vnops.c:vn_ioctl that checked if > > com was either SEEK_DATA or SEEK_HOLE and return EINVAL. While this > > worked for UFS, it disabled SEEK_[DATA,HOLE] for ZFS. > > I meant to just translate ENOTTY to EINVAL after calling VOP_IOCTL(). > The vop must be called to see what it wants to do. > The attached patch to kern/vfs_vnops.c translates ENOTTY to EINVAL after calling VOP_IOCTL for the SEEK_[DATA,HOLE] cases only. With this patch applied, the lseek03 test now returns with ENXIO on zfs filesystems, and EINVAL on non-zfs filesystems. Should all ENOTTY cases be changed to EINVAL, or just the SEEK_[DATA,HOLE] cases. Scot -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised. ------=_Part_117604_11761428.1178725054190 Content-Type: text/x-diff; name=vfs_vnops.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f1hy5j4y Content-Disposition: attachment; filename="vfs_vnops.patch" SW5kZXg6IHZmc192bm9wcy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL3N5 cy9rZXJuL3Zmc192bm9wcy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI0OApkaWZmIC11IC1y MS4yNDggdmZzX3Zub3BzLmMKLS0tIHZmc192bm9wcy5jCTEyIEZlYiAyMDA3IDIyOjUzOjAxIC0w MDAwCTEuMjQ4CisrKyB2ZnNfdm5vcHMuYwk5IE1heSAyMDA3IDEzOjEyOjA1IC0wMDAwCkBAIC03 NTUsNiArNzU1LDkgQEAKIAkJZWxzZQogCQkJZXJyb3IgPSBWT1BfSU9DVEwodnAsIGNvbSwgZGF0 YSwgZnAtPmZfZmxhZywKIAkJCSAgICBhY3RpdmVfY3JlZCwgdGQpOworCQkJaWYgKGVycm9yID09 IEVOT1RUWSAmJgorCQkJICAgIChjb20gPSBGSU9TRUVLREFUQSB8fCBjb20gPT0gRklPU0VFS0hP TEUpKQorCQkJCWVycm9yID0gRUlOVkFMOwogCQlicmVhazsKIAogCWRlZmF1bHQ6Cg== ------=_Part_117604_11761428.1178725054190--