From nobody Sun Feb 1 19:27:41 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f40CG0TQxz6QTG4 for ; Sun, 01 Feb 2026 19:28:10 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f40CF1y71z45dT for ; Sun, 01 Feb 2026 19:28:09 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 74.125.224.46 as permitted sender) smtp.mailfrom=6yearold@gmail.com Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-649b31e9010so1156281d50.3 for ; Sun, 01 Feb 2026 11:28:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769974088; x=1770578888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q+vVUfZiBpDqnIzq6HtFVDcN9V4ZYZnI4hl6ZlUfE40=; b=O5ssmFz3MS9IvJ4XqLvea/UDjkKs6/xWAVSuEdjkX1NeCIHvF3TytzJbPK5d30QG07 0hO6aQjMt6Cj0BEvP/GCsVOl17NUrPMxM7qHTFKEwpuzausz7fQzNS8CJCt3vySbJCcq tvM7+El7+oGhOKW6oDM6gm48545tvpL/iRpXsgxBSj4shS/R7FALXvR61RuzwVIas7xP hfnBYc6eTnbquRIdNcnI7tsNdPZP/H7pph6GJFRE/QIsi/in6F6kAZWF7q552HhXOmmw 0SZjU4HXR1EhP/j208v04TCwHbt7OpBZWiUXbBf272jrH49nyfooCq6Al75Jw1FY8OiX spNA== X-Forwarded-Encrypted: i=1; AJvYcCWTS9LgPMPenFVpMe7Jfe691Af299O2zGYOCnYT2iFI0VbL3wpS8ymOZFPjdba4XE4O8/o3Jirl7XQC9ZnVJWjoMU6yLA==@freebsd.org X-Gm-Message-State: AOJu0Yx+CBpz5UQGnGH0iwXBybyI3nssc+ouAcxwc1KaEC+/XylnDkPA 2dqv73PP/CVjwU04DfLQ41tybfIFFa5WYGF8H8yFZFDVgMbL+tmSjKS7RW0MYA== X-Gm-Gg: AZuq6aIEiuXsepcibPClWX9Xwn6gAq62UrGcTHtG+bLMMZNV2uk13yS7s0Us/l/8h3D p637DeRjAGaULjNoMKz6qg30nG6dsqphkk/+v6zLR5Nk7y9L6HKuUPCPL6vMJdcCrUQ1syqkS52 gGvhzH6UqXYzX/BDW7ELCWSSWFzzW3dYglaH2DMS3pBPa5G2gj0gifJP+WqnvL+6r97LuavFfhF 17Jp0TOUVrIiM5NZpu++y8FYLO5jejyHcySYcB6+MUPw9aX3AA4La1zwFSCzk9BFLu8l7SdVS8h 4z3PXWQLOONsqjF3Qv5OnMIu7iZdz67RvrrBvjDfVdJWElwdqHO12vge/bJme5SK2PS6mO4i5S9 fKI3Ec+v5fjOnFV2k+YqDZaTgvHbCTHePQDk/NMoXurd3uF1Pc4ud3cCRQ6xGJUPTj1eak0nqCX 1auLT+UQFuHNobkX0nzWRE4n0/GR72h2+8M4Ow71tYyrwzULWX/yYbLw4KzeN89pkcqsUKse03Y 5NYI0/DRNAQx3cUxuWbKljQfp0rUJumQCebwIWdwmGpfEAWMd0npDYZ0+0dva0DvB5CxCs= X-Received: by 2002:a53:de44:0:b0:649:5ed9:fb73 with SMTP id 956f58d0204a3-649a847354bmr5606357d50.50.1769974088320; Sun, 01 Feb 2026 11:28:08 -0800 (PST) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-649c195cd7fsm1770672d50.15.2026.02.01.11.28.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Feb 2026 11:28:07 -0800 (PST) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-79492a2a57bso35411007b3.2 for ; Sun, 01 Feb 2026 11:28:07 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUW++NoCdhFXfdQB+1qg6ABsi192o250ct89hSYy6KAprialp5eDxr7/GOKD22uAguo/hdOtF/RMRU/Qm06SvNBJon7vA==@freebsd.org X-Received: by 2002:a05:690c:84d:b0:794:7131:3dc3 with SMTP id 00721157ae682-7949df9bc20mr56288667b3.41.1769974086949; Sun, 01 Feb 2026 11:28:06 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <697499a8.335a0.2e12eda1@gitrepo.freebsd.org> In-Reply-To: From: Gleb Popov Date: Sun, 1 Feb 2026 22:27:41 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_Qg_xwXKX9aVs8JMQiZ2NQWJKcODdaHiykXihQ8rd0ykkgq8IRG36Z2t42A Message-ID: Subject: Re: git: 10037d0978f8 - main - fusefs: Implement support for the auto_unmount option kernel-side To: Konstantin Belousov , Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.85 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.988]; NEURAL_HAM_MEDIUM(-0.96)[-0.957]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:74.125.0.0/16:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:74.125.0.0/16, country:US]; RCVD_IN_DNSWL_NONE(0.00)[74.125.224.46:from,209.85.128.173:received]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; MISSING_XM_UA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[74.125.224.46:from]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4f40CF1y71z45dT X-Spamd-Bar: -- On Sun, Jan 25, 2026 at 10:39=E2=80=AFPM Konstantin Belousov wrote: > > > > + vfs_ref(fdata->mp); > Don't you need to take the reference when the fdata is created and mp mem= ber > is initialized, and not here? > > What guarantees that the mp is still ours? > In fact, I think that you should use vfs_busy() and not vfs_ref(), > since what prevents mp from being unmounted under us? Using vfs_busy() before dounmount() results in a soft hang: - vfs_busy increments mp->mnt_lockref in https://github.com/freebsd/freebsd-src/blob/98bdf63f6e94be42a1787de73608de1= 5bcb3419a/sys/kern/vfs_subr.c#L929 - dounmount spins until mp->mnt_lockref becomes 0 in https://github.com/freebsd/freebsd-src/blob/98bdf63f6e94be42a1787de73608de1= 5bcb3419a/sys/kern/vfs_mount.c#L2318-L2322 This results in a FUSE process to hang in the "mount drain" state.