Date: Thu, 21 Nov 2002 18:46:12 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: John Baldwin <john@baldwin.cx> Cc: qa@FreeBSD.org Subject: Re: sysinstall fstab bug Message-ID: <Pine.NEB.3.96L.1021121184536.77113C-100000@fledge.watson.org> In-Reply-To: <200211201530.gAKFUbjG001578@laptop.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks good to me in principle, but testing it would definitely be a good
direction to take this patch.
BTW, we should be putting together a testing guide for this release --
unfortunately, that means pretty much "Test everything" :-).
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
On Wed, 20 Nov 2002, John Baldwin wrote:
> sysinstall currently is using /dev/acd0c for /cdrom in the /etc/fstab it
> generates, but in 5.0 it should really be using /dev/acd0 w/o using a
> "fake" BSD 'c' partition. I think this patch will fix it but it hasn't
> been tested yet.
>
> Index: devices.c
> ===================================================================
> RCS file: /usr/cvs/src/usr.sbin/sysinstall/devices.c,v
> retrieving revision 1.142
> diff -u -r1.142 devices.c
> --- devices.c 13 Nov 2002 05:39:57 -0000 1.142
> +++ devices.c 20 Nov 2002 15:20:53 -0000
> @@ -61,13 +61,13 @@
> char *description;
> int major, minor, delta, max;
> } device_names[] = {
> - { DEVICE_TYPE_CDROM, "cd%dc", "SCSI CDROM drive", 15, 2, 8, 4 },
> - { DEVICE_TYPE_CDROM, "mcd%da", "Mitsumi (old model) CDROM drive", 29, 0, 8, 4 },
> - { DEVICE_TYPE_CDROM, "scd%da", "Sony CDROM drive - CDU31/33A type", 45, 0, 8, 4 },
> + { DEVICE_TYPE_CDROM, "cd%d", "SCSI CDROM drive", 15, 2, 8, 4 },
> + { DEVICE_TYPE_CDROM, "mcd%d", "Mitsumi (old model) CDROM drive", 29, 0, 8, 4 },
> + { DEVICE_TYPE_CDROM, "scd%d", "Sony CDROM drive - CDU31/33A type", 45, 0, 8, 4 },
> #ifdef notdef
> - { DEVICE_TYPE_CDROM, "matcd%da", "Matsushita CDROM ('sound blaster' type)", 46, 0, 8, 4 },
> + { DEVICE_TYPE_CDROM, "matcd%d", "Matsushita CDROM ('sound blaster' type)", 46, 0, 8, 4 },
> #endif
> - { DEVICE_TYPE_CDROM, "acd%dc", "ATAPI/IDE CDROM", 117, 0, 8, 4 },
> + { DEVICE_TYPE_CDROM, "acd%d", "ATAPI/IDE CDROM", 117, 0, 8, 4 },
> { DEVICE_TYPE_TAPE, "rsa%d", "SCSI tape drive", 14, 0, 16, 4 },
> { DEVICE_TYPE_TAPE, "rwt%d", "Wangtek tape drive", 10, 0, 1, 4 },
> { DEVICE_TYPE_DISK, "da%d", "SCSI disk device", 13, 65538, 8, 16 },
>
> --
> John Baldwin <jhb@FreeBSD.org>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-qa" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-qa" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021121184536.77113C-100000>