From owner-cvs-src-old@FreeBSD.ORG  Wed Apr  6 21:18:20 2011
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6C8F31065675
	for <cvs-src-old@freebsd.org>; Wed,  6 Apr 2011 21:18:20 +0000 (UTC)
	(envelope-from adrian@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EB8D8FC0A
	for <cvs-src-old@freebsd.org>; Wed,  6 Apr 2011 21:18:20 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p36LIK29009545
	for <cvs-src-old@freebsd.org>; Wed, 6 Apr 2011 21:18:20 GMT
	(envelope-from adrian@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p36LIKwr009544
	for cvs-src-old@freebsd.org; Wed, 6 Apr 2011 21:18:20 GMT
	(envelope-from adrian@repoman.freebsd.org)
Message-Id: <201104062118.p36LIKwr009544@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	adrian@repoman.freebsd.org using -f
From: Adrian Chadd <adrian@FreeBSD.org>
Date: Tue, 5 Apr 2011 06:46:07 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/mips/atheros if_arge.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2011 21:18:20 -0000

adrian      2011-04-05 06:46:07 UTC

  FreeBSD src repository

  Modified files:
    sys/mips/atheros     if_arge.c 
  Log:
  SVN rev 220357 on 2011-04-05 06:46:07Z by adrian
  
  if_arge has had a strange bug that only appears during high traffic
  levels. TX would hang, RX wouldn't. A bit of digging showed the interface
  send queue was full, but IFF_DRV_OACTIVE was clear and the hardware TX
  queue was empty.
  
  It turns out that there wasn't a check to drain the interface send
  queue once hardware TX had completed, so if the interface send queue
  had filled up in the meantime, subsequent packets would be dropped
  by the higher layers and if_start (and thus arge_start()) would never
  be called.
  
  The fix is simple - call arge_start_locked() in the software interrupt
  handler after the hardware TX queue has been handled or a TX underrun
  occured. This way the interface send queue gets drained.
  
  Revision  Changes    Path
  1.17      +21 -0     src/sys/mips/atheros/if_arge.c