From owner-svn-src-all@freebsd.org  Thu Mar  3 11:29:13 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 96CEDA93C5D;
 Thu,  3 Mar 2016 11:29:13 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 31508CD2;
 Thu,  3 Mar 2016 11:29:13 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u23BT8nZ080122
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Thu, 3 Mar 2016 13:29:09 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u23BT8nZ080122
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id u23BT8aJ080121;
 Thu, 3 Mar 2016 13:29:08 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 3 Mar 2016 13:29:08 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Hans Petter Selasky <hps@selasky.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r296320 - in head/sys: kern sys
Message-ID: <20160303112908.GP67250@kib.kiev.ua>
References: <201603021846.u22IkHWM010861@repo.freebsd.org>
 <56D81918.6020403@selasky.org> <56D81A70.2070508@selasky.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56D81A70.2070508@selasky.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 11:29:13 -0000

On Thu, Mar 03, 2016 at 12:05:20PM +0100, Hans Petter Selasky wrote:
> On 03/03/16 11:59, Hans Petter Selasky wrote:
> > +/* Flags for callout_stop_safe() */
> > +#define    CS_DRAIN        0x0001 /* callout_drain(), wait allowed */
> > +#define    CS_MIGRBLOCK        0x0002 /* Block migration, return value
> > +                      indicates that the callout was
> > +                          executing */
> > +
> >    #ifdef _KERNEL
> 
> Should these defines be under #ifdef _KERNEL ?

Why do they need the braces ?  Other bits in the callout.h header are
not restricted for kernel only, and I do not see a difference between
CALLOUT_* and CS_*.