From owner-svn-src-head@FreeBSD.ORG Mon Nov 17 20:04:34 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 424A91065673; Mon, 17 Nov 2008 20:04:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id D09A78FC19; Mon, 17 Nov 2008 20:04:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1L2AKm-0004n4-4D; Mon, 17 Nov 2008 22:04:32 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mAHK4SnM023085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Nov 2008 22:04:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mAHK4SRm020727; Mon, 17 Nov 2008 22:04:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mAHK4Rr4020726; Mon, 17 Nov 2008 22:04:27 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 17 Nov 2008 22:04:27 +0200 From: Kostik Belousov To: "M. Warner Losh" Message-ID: <20081117200427.GI90129@deviant.kiev.zoral.com.ua> References: <200811170237.mAH2bjY5088186@ambrisko.com> <200811171211.42740.jhb@freebsd.org> <20081117193541.GG90129@deviant.kiev.zoral.com.ua> <20081117.125310.-233674490.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uJWb33pM2TcUAXIl" Content-Disposition: inline In-Reply-To: <20081117.125310.-233674490.imp@bsdimp.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1L2AKm-0004n4-4D 663f96a8955034620c56d8d8cce3a8ab X-Terabit: YES Cc: ambrisko@freebsd.org, src-committers@freebsd.org, ambrisko@ambrisko.com, jhb@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r184974 - head/sys/dev/mfi X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2008 20:04:34 -0000 --uJWb33pM2TcUAXIl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2008 at 12:53:10PM -0700, M. Warner Losh wrote: > In message: <20081117193541.GG90129@deviant.kiev.zoral.com.ua> > Kostik Belousov writes: > : diff --git a/sys/kern/imgact_aout.c b/sys/kern/imgact_aout.c > : index f4e4614..114e0ba 100644 > : --- a/sys/kern/imgact_aout.c > : +++ b/sys/kern/imgact_aout.c > : @@ -82,7 +82,17 @@ struct sysentvec aout_sysvec =3D { > : .sv_copyout_strings =3D exec_copyout_strings, > : .sv_setregs =3D exec_setregs, > : .sv_fixlimit =3D NULL, > : - .sv_maxssiz =3D NULL > : + .sv_maxssiz =3D NULL, > : + .sv_flags =3D SV_NATIVE | SV_AOUT | > : +#if defined(__i386__) > : + SV_IA32 | SV_ILP32 > : +#elif defined(__powerpc__) || defined(__mips__) > : + SV_ILP32 > : +#elif defined(__ia64__) || defined(__sparc64__) || defined(__amd64__) > : + SV_LP64 > : +#else > : +#error Choose SV_XXX flags for the platform > : +#endif > : }; >=20 > I didn't think we supported aout for mips. Also, arm is missing from > the list :-) Thanks. In fact, aout works for i386 (and pc98) only. I changed the #ifdef to the following: diff --git a/sys/kern/imgact_aout.c b/sys/kern/imgact_aout.c index f4e4614..78055f7 100644 --- a/sys/kern/imgact_aout.c +++ b/sys/kern/imgact_aout.c @@ -82,7 +82,13 @@ struct sysentvec aout_sysvec =3D { .sv_copyout_strings =3D exec_copyout_strings, .sv_setregs =3D exec_setregs, .sv_fixlimit =3D NULL, - .sv_maxssiz =3D NULL + .sv_maxssiz =3D NULL, + .sv_flags =3D SV_NATIVE | SV_AOUT | +#if defined(__i386__) + SV_IA32 | SV_ILP32 +#else +#error Choose SV_XXX flags for the platform +#endif }; =20 static int --uJWb33pM2TcUAXIl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkkhzksACgkQC3+MBN1Mb4i5MACfd4UDfKXImrIYHVjEOpRzhxzI ZakAoLiFwX5L5geI1B1IOrpdhjuKdzCV =HPp6 -----END PGP SIGNATURE----- --uJWb33pM2TcUAXIl--