Date: Tue, 28 Nov 2023 14:44:12 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: Randall Stewart <rrs@FreeBSD.org> Cc: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 6a79e48076bc - main - Fix two latent bugs in hpts. One where a static is put on a local variable, the other an initialization bug where we should be setting tv.tv_sec to 0. Message-ID: <737498435.7036.1701179052815@localhost> In-Reply-To: <202311271939.3ARJdQJK020166@gitrepo.freebsd.org> References: <202311271939.3ARJdQJK020166@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_7035_2050740070.1701179052803 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit The PR you mention gives me the friendly message of " You must enter a valid bug number! " https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275482 Typo somewhere? A quick search gives me https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275382 which looks a lot like what you describe in the commit. Regards, Ronald. Van: Randall Stewart <rrs@FreeBSD.org> Datum: maandag, 27 november 2023 20:39 Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Onderwerp: git: 6a79e48076bc - main - Fix two latent bugs in hpts. One where a static is put on a local variable, the other an initialization bug where we should be setting tv.tv_sec to 0. > > The branch main has been updated by rrs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6a79e48076bcce3e902323e62689eacb98faa180 > > commit 6a79e48076bcce3e902323e62689eacb98faa180 > Author: Randall Stewart <rrs@FreeBSD.org> > AuthorDate: 2023-11-27 19:38:06 +0000 > Commit: Randall Stewart <rrs@FreeBSD.org> > CommitDate: 2023-11-27 19:38:06 +0000 > > Fix two latent bugs in hpts. One where a static is put on > a local variable, the other an initialization bug where > we should be setting tv.tv_sec to 0. > > PR: 275482 > --- > sys/netinet/tcp_hpts.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/netinet/tcp_hpts.c b/sys/netinet/tcp_hpts.c > index 92b2f69c9e58..d673ccbe4a73 100644 > --- a/sys/netinet/tcp_hpts.c > +++ b/sys/netinet/tcp_hpts.c > @@ -1519,6 +1519,7 @@ __tcp_run_hpts(struct tcp_hpts_entry *hpts) > hpts->p_mysleep.tv_usec = dynamic_min_sleep; > /* Reschedule with new to value */ > tcp_hpts_set_max_sleep(hpts, 0); > + tv.tv_sec = 0; > tv.tv_usec = hpts->p_hpts_sleep_time * HPTS_TICKS_PER_SLOT; > /* Validate its in the right ranges */ > if (tv.tv_usec < hpts->p_mysleep.tv_usec) { > @@ -1600,7 +1601,7 @@ tcp_choose_hpts_to_run(void) > void > tcp_run_hpts(void) > { > - static struct tcp_hpts_entry *hpts; > + struct tcp_hpts_entry *hpts; > struct epoch_tracker et; > > NET_EPOCH_ENTER(et); > > > > ------=_Part_7035_2050740070.1701179052803 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit <html><head></head><body><br> The PR you mention gives me the friendly message of<br> <br> " <div class="throw_error" id="error_msg">You must enter a valid bug number!</div> <p id="post_err_msg">"</p> <br> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275482<br>; <br> Typo somewhere?<br> <br> A quick search gives me https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275382 which looks a lot like what you describe in the commit.<br> <br> Regards,<br> Ronald.<br> <br> <p><strong>Van:</strong> Randall Stewart <rrs@FreeBSD.org><br> <strong>Datum:</strong> maandag, 27 november 2023 20:39<br> <strong>Aan:</strong> src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org<br> <strong>Onderwerp:</strong> git: 6a79e48076bc - main - Fix two latent bugs in hpts. One where a static is put on a local variable, the other an initialization bug where we should be setting tv.tv_sec to 0.</p> <blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px"> <div class="MessageRFC822Viewer" id="P"> <div class="TextPlainViewer" id="P.P">The branch main has been updated by rrs:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=6a79e48076bcce3e902323e62689eacb98faa180">https://cgit.FreeBSD.org/src/commit/?id=6a79e48076bcce3e902323e62689eacb98faa180</a><br>; <br> commit 6a79e48076bcce3e902323e62689eacb98faa180<br> Author: Randall Stewart <rrs@FreeBSD.org><br> AuthorDate: 2023-11-27 19:38:06 +0000<br> Commit: Randall Stewart <rrs@FreeBSD.org><br> CommitDate: 2023-11-27 19:38:06 +0000<br> <br> Fix two latent bugs in hpts. One where a static is put on<br> a local variable, the other an initialization bug where<br> we should be setting tv.tv_sec to 0.<br> <br> PR: 275482<br> ---<br> sys/netinet/tcp_hpts.c | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br> <br> diff --git a/sys/netinet/tcp_hpts.c b/sys/netinet/tcp_hpts.c<br> index 92b2f69c9e58..d673ccbe4a73 100644<br> --- a/sys/netinet/tcp_hpts.c<br> +++ b/sys/netinet/tcp_hpts.c<br> @@ -1519,6 +1519,7 @@ __tcp_run_hpts(struct tcp_hpts_entry *hpts)<br> hpts->p_mysleep.tv_usec = dynamic_min_sleep;<br> /* Reschedule with new to value */<br> tcp_hpts_set_max_sleep(hpts, 0);<br> + tv.tv_sec = 0;<br> tv.tv_usec = hpts->p_hpts_sleep_time * HPTS_TICKS_PER_SLOT;<br> /* Validate its in the right ranges */<br> if (tv.tv_usec < hpts->p_mysleep.tv_usec) {<br> @@ -1600,7 +1601,7 @@ tcp_choose_hpts_to_run(void)<br> void<br> tcp_run_hpts(void)<br> {<br> - static struct tcp_hpts_entry *hpts;<br> + struct tcp_hpts_entry *hpts;<br> struct epoch_tracker et;<br> <br> NET_EPOCH_ENTER(et);<br> </div> <hr></div> </blockquote> <br> </body></html> ------=_Part_7035_2050740070.1701179052803--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?737498435.7036.1701179052815>