From owner-dev-commits-src-all@freebsd.org  Mon Jun 28 20:00:07 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C73165B23A;
 Mon, 28 Jun 2021 20:00:07 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com
 [209.85.167.42])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GDJP26yKRz4SfR;
 Mon, 28 Jun 2021 20:00:06 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by mail-lf1-f42.google.com with SMTP id f30so34878490lfj.1;
 Mon, 28 Jun 2021 13:00:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=il9R1eWAYma3gXtN3ScdR9SJc8DYFCMTzclVIosvEj0=;
 b=JyGO4Vqkk1g7t2FNYz0KO6ad8bxYAyqYhyPyQxu+JIbJIleXIuln0zT6ZsugEzkIk2
 MuFBBzvomwBzdcYCWmsoivdKEW1P5cKAdy/HXiVkmp5VW0QBLgwLNBYGXn+o/eCF1No/
 0k6MrTWohU2SIGHpv9of8jdeoY9De8G6FeLZUfISJO8ULV1riot4OpyagVPbwp6wT9m3
 1Z/w0uCY8YZDw0qf09uBW/3tmbwy+T2D/dUVEGflE/xq6oBQ+YDyOk0qBT1G+iV3YL7s
 qBytbqpDisopcE5buqhAg/EGsl6sf19H0UQcQEEeeSpD8QbOfQ7ZGiYq3PY/VPbJP6ml
 oO2A==
X-Gm-Message-State: AOAM5333Fa7MosQ3yLkzaA2FsNydC0ack1T/WeRbxrdS4bvHlPGFw7MM
 wjcf6M/c5zAPoUFMwB2jVNxnWWvqAUPxrtLmOA9w78Vt
X-Google-Smtp-Source: ABdhPJyzfqLvheniKRmXtX+yXBlxjhseE5+CKnmcSNgVpVahI9BaOTcR3sEacR0s9FAJl/QMxjd7G4S2ehQruPa7BH4=
X-Received: by 2002:ac2:4310:: with SMTP id l16mr5978972lfh.481.1624910403829; 
 Mon, 28 Jun 2021 13:00:03 -0700 (PDT)
MIME-Version: 1.0
References: <202106271712.15RHConb019042@gitrepo.freebsd.org>
 <202106281630.15SGU2j0097041@gndrsh.dnsmgr.net>
In-Reply-To: <202106281630.15SGU2j0097041@gndrsh.dnsmgr.net>
From: Ed Maste <emaste@freebsd.org>
Date: Mon, 28 Jun 2021 15:59:42 -0400
Message-ID: <CAPyFy2DdB2WZ0pmW0GbU-M5EBxkdp8H8HkUmir8qmHHHSbe-hQ@mail.gmail.com>
Subject: Re: git: b762974cf4b9 - main - clang: stop linking _p libs for -pg as
 of FreeBSD 14
To: "Rodney W. Grimes" <rgrimes@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, 
 "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,
 dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 4GDJP26yKRz4SfR
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2021 20:00:07 -0000

> >     clang: stop linking _p libs for -pg as of FreeBSD 14
> >
> >     In FreeBSD 14 we will stop providing _p libraries (compiled with -pg).
>
> So if this is being done in 14 only, why is there a MFC marker?
> Should that of been MFC: never?
...
> > +  bool Profiling = Args.hasArg(options::OPT_pg) &&
> > +                   ToolChain.getTriple().getOSMajorVersion() < 14;

The compiler applies this logic only to 14 and later. MFCing will
allow a FreeBSD 13 Clang to build a FreeBSD 14 binary with -pg.