Date: Wed, 13 Oct 2010 11:50:26 +0300 From: Jaakko Heinonen <jh@FreeBSD.org> To: freebsd-geom@FreeBSD.org Subject: Re: HEADS UP: device name checking on device registration Message-ID: <20101013085025.GB54686@jh> In-Reply-To: <20101007180657.GA1383@a91-153-123-205.elisa-laajakaista.fi> References: <20101007180657.GA1383@a91-153-123-205.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
[Posting a patch to -geom for comments.] On 2010-10-07, Jaakko Heinonen wrote: > Currently several GEOM classes (notably geom_label) allow to create > devices with invalid names. Below is a link to a patch which converts > g_dev_taste() to use make_dev_p() with MAKEDEV_CHECKNAME flag. It's not > a complete solution and essentially changes the panic to a printf. What do you think about this patch? http://people.freebsd.org/~jh/patches/geom_dev-checkname.2.diff Any better ideas how to handle this in GEOM? It doesn't seem to be trivial to propagate an error from g_dev_taste() due to asynchronous nature of the device registration in GEOM. -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101013085025.GB54686>