From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Jan 25 00:40:04 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0841116A418
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri, 25 Jan 2008 00:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E8A6313C465
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri, 25 Jan 2008 00:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0P0e3cX095745
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Fri, 25 Jan 2008 00:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0P0e3Ct095744;
	Fri, 25 Jan 2008 00:40:03 GMT (envelope-from gnats)
Date: Fri, 25 Jan 2008 00:40:03 GMT
Message-Id: <200801250040.m0P0e3Ct095744@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Jona Joachim <jaj@hcl-club.lu>
Cc: 
Subject: Re: ports/119908: [maintainer] multimedia/handbrake
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jona Joachim <jaj@hcl-club.lu>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jan 2008 00:40:04 -0000

The following reply was made to PR ports/119908; it has been noted by GNATS.

From: Jona Joachim <jaj@hcl-club.lu>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/119908: [maintainer] multimedia/handbrake
Date: Fri, 25 Jan 2008 01:34:08 +0100

 The above patch is not very clean and I forgot to remove the BROKEN
 section.
 Here is a better and cleaner version of the patch.
 It was successfully tested on amd64 by elliot.schlegelmilch AT
 gmail.com.
 
 --- /usr/ports/multimedia/handbrake/Makefile	2008-01-18
 08:32:28.000000000 +0100 +++ Makefile	2008-01-24
 21:01:16.000000000 +0100 @@ -7,6 +7,7 @@
  
  PORTNAME=	handbrake
  PORTVERSION=	0.9.1
 +PORTREVISION=	1
  CATEGORIES=	multimedia
  MASTER_SITES=
 http://saintdevelopment.com/mirror/handbrake/:main \
 http://junk.phantomgorilla.com/hb/:main \ @@ -59,15 +60,12 @@
  WRKSRC=		${WRKDIR}/HandBrake
  PLIST_FILES=	bin/handbrake
  
 -JAM?=		${LOCALBASE}/bin/jam
 +# -dx: verbose build, -q: quit immediately upon first error
 +JAM?=		${LOCALBASE}/bin/jam -dx -q
  APPLY?=		/usr/bin/apply
  
  .include <bsd.port.pre.mk>
  
 -.if ${ARCH} == "amd64"
 -BROKEN=		Does not compile
 -.endif
 -
  # nasm/yasm needed by x264
  .if ${ARCH}=="i386"
  BUILD_DEPENDS+=	nasm:${PORTSDIR}/devel/nasm
 @@ -75,6 +73,11 @@
  BUILD_DEPENDS+=	yasm>=0.6.0:${PORTSDIR}/devel/yasm
  .endif
  
 +# needed for amd64, doesn't work with i386
 +.if ${ARCH}!="i386"
 +CFLAGS+=	-fPIC -DPIC
 +.endif
 +
  CONFIGURE_ENV+=	PKG_CONFIG_PATH=${WRKSRC}/contrib/lib/pkgconfig
  MAKE_ENV+=	ARCH=${ARCH} MAKE=${GMAKE}
  
 @@ -118,9 +121,8 @@
  		s|$$PREFIX|${WRKSRC}/contrib|g' \
  			${WRKSRC}/contrib/ffmpeg/configure
  
 -# jam -dx, it will giving a verbose of build.
  do-build:
 -	@(cd ${WRKSRC} ; ${SETENV} ${MAKE_ENV} ${JAM} -dx)
 +	@(cd ${WRKSRC} ; ${SETENV} ${MAKE_ENV} ${JAM})
  
  do-install:
  	${INSTALL_PROGRAM} ${WRKSRC}/HandBrakeCLI
 ${PREFIX}/bin/handbrake