From owner-svn-ports-all@freebsd.org Sun Feb 28 16:36:31 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BCD7E56FCB5; Sun, 28 Feb 2021 16:36:31 +0000 (UTC) (envelope-from danfe@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DpTYW4z1Gz4X4t; Sun, 28 Feb 2021 16:36:31 +0000 (UTC) (envelope-from danfe@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9D63714019; Sun, 28 Feb 2021 16:36:31 +0000 (UTC) (envelope-from danfe@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 11SGaVQ9039467; Sun, 28 Feb 2021 16:36:31 GMT (envelope-from danfe@FreeBSD.org) Received: (from danfe@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 11SGaVUq039466; Sun, 28 Feb 2021 16:36:31 GMT (envelope-from danfe@FreeBSD.org) Message-Id: <202102281636.11SGaVUq039466@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: danfe set sender to danfe@FreeBSD.org using -f From: Alexey Dokuchaev Date: Sun, 28 Feb 2021 16:36:31 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r566774 - head/deskutils/gworkspace X-SVN-Group: ports-head X-SVN-Commit-Author: danfe X-SVN-Commit-Paths: head/deskutils/gworkspace X-SVN-Commit-Revision: 566774 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2021 16:36:31 -0000 Author: danfe Date: Sun Feb 28 16:36:31 2021 New Revision: 566774 URL: https://svnweb.freebsd.org/changeset/ports/566774 Log: 1) The -fno-common fix attempt in r561452 was actually wrong: it marked the declaration of the variable ``serverConnection'' as extern, but there is no corresponding definition of the variable, so it remained an unresolved symbol (that didn't result in a build failure, because GNUstep applications are linked as a shared object) 2) GC leftovers from r132311: unreferenced ADDITIONAL_LDFLAGS and bogus USES+=ghostscript (PDF viewer requires PDFKit framework which is not available from the Ports Collection) Reported by: naddy (1) Obtained from: Debian Modified: head/deskutils/gworkspace/Makefile Modified: head/deskutils/gworkspace/Makefile ============================================================================== --- head/deskutils/gworkspace/Makefile Sun Feb 28 15:46:12 2021 (r566773) +++ head/deskutils/gworkspace/Makefile Sun Feb 28 16:36:31 2021 (r566774) @@ -2,7 +2,7 @@ PORTNAME= gworkspace PORTVERSION= 0.9.4 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= deskutils gnustep #MASTER_SITES= http://www.gnustep.it/enrico/gworkspace/ MASTER_SITES= GNUSTEP/usr-apps @@ -17,19 +17,6 @@ USE_GNUSTEP= back build USE_LDCONFIG= ${GNUSTEP_SYSTEM_LIBRARIES} GNU_CONFIGURE= yes -ADDITIONAL_LDFLAGS+= -L${WRKSRC}/FSNode/FSNode.framework/Versions/A - -.if defined(WITHOUT_GHOSTSCRIPT) -PLIST_SUB+= PDFVIEW="@comment " -.else -PLIST_SUB+= PDFVIEW="" -USES+= ghostscript -.endif - -post-patch: -# Fix the build with -fno-common (for Clang 11 and GCC 10) - @${REINPLACE_CMD} -e '/serverConnection/s,^,extern ,' \ - ${WRKSRC}/Inspector/ContentViewers/ImageViewer/Resizer.h pre-configure: ${RM} -r ${WRKSRC}/GWMetadata