From owner-freebsd-current@FreeBSD.ORG Mon Feb 9 06:50:07 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB0051065670 for ; Mon, 9 Feb 2009 06:50:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 6E8178FC0C for ; Mon, 9 Feb 2009 06:50:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id AFB6B41C7B6; Mon, 9 Feb 2009 07:50:05 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id ZBfobgWm6-pJ; Mon, 9 Feb 2009 07:50:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 56A0241C7BB; Mon, 9 Feb 2009 07:50:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 1DCF74448EC; Mon, 9 Feb 2009 06:48:31 +0000 (UTC) Date: Mon, 9 Feb 2009 06:48:31 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Michael Proto In-Reply-To: <1de79840902081724k243fc300n97dd4f430e0c6cde@mail.gmail.com> Message-ID: <20090209064718.C93725@maildrop.int.zabbadoz.net> References: <7d6fde3d0902081659i7cb86al921ea109d17e1a3c@mail.gmail.com> <1de79840902081724k243fc300n97dd4f430e0c6cde@mail.gmail.com> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Garrett Cooper , FreeBSD Current , Randall Stewart Subject: Re: WITHOUT_INET6 broken on CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2009 06:50:08 -0000 On Sun, 8 Feb 2009, Michael Proto wrote: > On Sun, Feb 8, 2009 at 7:59 PM, Garrett Cooper wrote: >> Hi Randall, >> I recently rebuilt my sources today and I noticed that it's now >> breaking on a valid warning with sctp: >> ... >> /usr/src/sys/netinet/sctputil.c >> cc1: warnings being treated as errors >> In file included from /usr/src/sys/netinet/sctputil.c:6553: >> /usr/src/sys/netinet6/sctp6_var.h:57: warning: 'struct icmp6_hdr' >> declared inside parameter list >> /usr/src/sys/netinet6/sctp6_var.h:57: warning: its scope is only this >> definition or declaration, which is probably not what you want >> *** Error code 1 ... >> I'm going to rebuild setting WITHOUT_SCTP for now, but this needs >> to be fixed. > > IIRC SCTP has always required INET6 to compile since it was first > introduced. I thought it was a prerequisite. No, we've always fixed it. I have sent this patch to Randall last weekend: Index: sys/netinet/sctputil.c =================================================================== --- sys/netinet/sctputil.c (revision 188293) +++ sys/netinet/sctputil.c (working copy) @@ -6550,7 +6550,6 @@ #include #include #include -#include static void sctp_recv_udp_tunneled_packet(struct mbuf *m, int off, struct inpcb *ignored) -- Bjoern A. Zeeb The greatest risk is not taking one.