From nobody Mon Jun 2 17:37:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bB1Jb6q7Qz5x6rK for ; Mon, 02 Jun 2025 17:37:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bB1Jb5tprz3xZk for ; Mon, 02 Jun 2025 17:37:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-b2d46760950so4495216a12.3 for ; Mon, 02 Jun 2025 10:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1748885865; x=1749490665; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PNpWa7Cz+PR2mVxhLS3mEt+U1XAWTpWeB3g4MhzmAUE=; b=1AVaLYzcgzOQch8lAwdjRBwXIaConOJtFr2qv7UbGm51CEEETTUb0YXYlGOrV0RcJf 2dm+bBZSVgoIMALBKyYkPNR59BMbJ3pWfliy9EU/q3fSI+6q60Ep+d/kT+J+pO+lyJII Pv5ve7IMaGw/IHm2a1/Dm3aNi/kb4m/Ycpf4JKldEOVWTxmYPSVLDUzFqzY16ReLWAcl 0PrxQayDxni2qByddGEvS3x4fRZyDiDhvAuSYG/9EGqFAt6s1MIaKrYxgytVuCjl7723 wOMHvWMD0vzEnTDd2NQ9t04O6KlPtzKHBNrGo2eBtIw+Y7hu1Qg4yaqWquTowBH7QNLV X2Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748885865; x=1749490665; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PNpWa7Cz+PR2mVxhLS3mEt+U1XAWTpWeB3g4MhzmAUE=; b=YDpF9/HgGC965pQwjxZQ2SZeZiF+WFlmMKK1mwWSwAw3XmFsDVpx1/rpB6f1HX04YG sjGZD7YGlKwTENzWB6e46x2Cduj3LUIIMUEpIL490Bn6aEQ1Xx2IJo+TwNuwSCNMdI7l cCsnzSr/PRGhWMu1IoEuXF4c2nt+8JkP+R2AaegWMVSN3bz+cH/y7ia8GK72fioAamHs NsfXDxhxOXOZTiCf1SRUDjG78f3s/f1sr8p2F98dPiZQkvIQskGMvBXZRbbib4K3M/CD UkYsdjRfV/o9tSdQWaaE0/K9oAeSljQfytSdB/Wc2BijibkUaZjU17DTGvt1kL5yJl6G IPfw== X-Forwarded-Encrypted: i=1; AJvYcCVHo9PFlp6eSJXjnTsw2/pGD8M9HL9hqItsEKaQ53/WFluzLVka2/lbAf07YY/U3Rc3ep4tWbvDIzwVrtR02gapKBpI@freebsd.org X-Gm-Message-State: AOJu0YwWT5fwD0gHbt7g8n4w8kAz2g6zCiUJEUE6G/nZFhePyfjHTd9c jgaxVXv4QcWS0d0SxLX5GjOy9XKhZOiQzUdiTUdi5KUskdIawsjtLwV81CDCZJWoj21aJZVbsZD 3Gsz+zaqtsUUz0uSJoaCWWEh05QUbG835WJqpUX3mSA== X-Gm-Gg: ASbGncsAjQou3wlpEhiUf+S4iqqyWeOG7QCHRYalUZCyPqnORHxmRRYMr0xfJVLAjdp uvnzB7PdlAVonQlAsobAcXxpK5qtayp/hdJXFHX7JXXxLfbe0TVExNu70atUxbQwEfmGyTy/fwJ jh6vivxE24Gkn8lNv9aBcTJ8wZXSMHtxYB X-Google-Smtp-Source: AGHT+IFqT7t/89JlaovDlIX0x9sUNZ6zXI0wiGe5fYxrJnFKsv9XES7z3xsReSv/b5e+P4JRRYxEcH9346e/4SnO8Uk= X-Received: by 2002:a17:90a:ec84:b0:311:f684:d3cd with SMTP id 98e67ed59e1d1-3127c6d7105mr17136987a91.12.1748885865262; Mon, 02 Jun 2025 10:37:45 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202506020549.5525nuDu054998@gitrepo.freebsd.org> <24533e37-2396-40ef-ba84-a5339b811527@FreeBSD.org> In-Reply-To: <24533e37-2396-40ef-ba84-a5339b811527@FreeBSD.org> From: Warner Losh Date: Mon, 2 Jun 2025 11:37:34 -0600 X-Gm-Features: AX0GCFuYCkYv0PV0Ueo6ZBroYgOBgzR3pieGlzSgkISE8zfsDHUXCckxaarBbew Message-ID: Subject: Re: git: 61d77e6c0095 - main - loader: allow for exceptions to restricted settings. To: Kyle Evans Cc: "Simon J. Gerraty" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bB1Jb5tprz3xZk X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Mon, Jun 2, 2025 at 10:14=E2=80=AFAM Kyle Evans wro= te: > > On 6/2/25 00:49, Simon J. Gerraty wrote: > > The branch main has been updated by sjg: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D61d77e6c009544d1489078c1= 6a5d22b27d25c91b > > > > commit 61d77e6c009544d1489078c16a5d22b27d25c91b > > Author: Simon J. Gerraty > > AuthorDate: 2025-06-02 05:48:43 +0000 > > Commit: Simon J. Gerraty > > CommitDate: 2025-06-02 05:48:43 +0000 > > > > loader: allow for exceptions to restricted settings. > > > > We restrict what an unverified loader.conf etc can set, > > and the same restrictions are applied to interactive input. > > We need to allow for exceptions (eg boot_verbose). > > It is best if any allowed settings match up to '=3D'. > > > > If we do not allow it to be set, do not allow it to be unset > > > > Reviewed by: stevek > > Sponsored by: Juniper Networks, Inc. > > --- > Long-term, we should probably work out something that can work for > lualoader, too. We use setenv() there directly rather than adding a > layer of indirection through the command-line parser. Yea, I'd rather this be a property of the env variable than having lists li= ke this anyway. And that would solve another problem I have from time to time which is needing to have an always existing env variable with a default, bu= t overridable value. In these cases, you have to set that up in code, and it'= s a bit of a bother. If we do it right, we could have a three-fer: works with lua, works to set certain things immutable after a time and also lets us initialize th= ings. Though getting the details right so that we can set these in loader.conf, but then not set them on the command line is the most likely use case, and I thought for that use case we did the right thing in lualoader. no? Warner