From owner-svn-src-projects@freebsd.org  Thu Nov 16 21:15:17 2017
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DF8FDE9599
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Thu, 16 Nov 2017 21:15:17 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1459A6A9DF;
 Thu, 16 Nov 2017 21:15:16 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.128.70])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id B1B272603AE;
 Thu, 16 Nov 2017 22:15:13 +0100 (CET)
Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9
To: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-projects@freebsd.org
References: <201711161513.vAGFDThx060235@repo.freebsd.org>
 <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org>
Date: Thu, 16 Nov 2017 22:12:26 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 21:15:17 -0000

On 11/16/17 17:56, Bryan Drewery wrote:
> On 11/16/2017 7:13 AM, Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Thu Nov 16 15:13:28 2017
>> New Revision: 325894
>> URL: https://svnweb.freebsd.org/changeset/base/325894
>>
>> Log:
>>    Update list of hardcoded OFED build order dependencies for
>>    the buildworld target.
>>    
>>    Sponsored by:	Mellanox Technologies
>>
>> Modified:
>>    projects/bsd_rdma_4_9/Makefile.inc1
>>

Hi,

>>
> 
> This isn't right, you don't need to include any 'include' directories in
> here as 'make includes' is ran before 'make libraries'.

I tried leaving the include directory out and it failed.

> 
> You don't need libthr either as it is in prebuild_libs which is built
> before all of this.

OK. I'll update it tomorrow.

> 
> I suspect the actual change needed is far smaller than this.
> 

Thank you for your review.

--HPS