From owner-freebsd-hackers@freebsd.org Thu Jan 16 09:19:21 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 45F8A22FAF3 for ; Thu, 16 Jan 2020 09:19:21 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47yzCr0J6mz3DS3 for ; Thu, 16 Jan 2020 09:19:19 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 2D7283C0199; Thu, 16 Jan 2020 09:19:19 +0000 (UTC) Date: Thu, 16 Jan 2020 09:19:19 +0000 From: Brooks Davis To: Rares Aioanei Cc: FreeBSD Hackers Subject: Re: Clean up GNU-isms in base? Message-ID: <20200116091919.GA21259@spindle.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 47yzCr0J6mz3DS3 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-5.52 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; IP_SCORE(-3.62)[ip: (-9.50), ipnet: 199.48.128.0/22(-4.74), asn: 36236(-3.83), country: US(-0.05)] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2020 09:19:21 -0000 --opJtzjQTFsWo+cga Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 16, 2020 at 10:17:26AM +0200, Rares Aioanei wrote: > While compiling world with extra warnings I noticed compiler messages > about GNU extensions being used in the code, for example the use of typeof() or > warnings like this : "/usr/src/lib/libpmc/pmu-events/json.h:22:35: > warning: token pasting of ',' and __VA_ARGS__ is a GNU extension > [-Wgnu-zero-variadic-macro-arguments]". Question is : is there an > interest in doing a "clean-up" of such constructs in the code? To the extent that the standard provides a useful mechanism (as, IIRC, it does here), I think this is a good idea. Right now we're probably confined to mechanisms supported in C99, but once we've finished kicking gcc 4.2.1 out later this year, we'll be able to use C11 features. -- Brooks --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeICqWAAoJEKzQXbSebgfA8Q0H/jzWaIUmmUC+sroK5KXVnkW3 nBSvhFzRltdZEd84JYcz5ZZBJiyY0RcNwIRosptBr5XBqi5lGCzgYIcfJU815IWR EBLbjsvJMQebctDyLTDcISK0FXDZPg6F3A7wXFdR11uNWX6c99ffyAQH30irtEO0 wL9f1mGVIszXP6lEvxXrRhj4GR1RVTnBnKL5Wbc5s/8h8WqeckaTUgcU/GB43KsN L2iRnvbe1NRYeIzbKhnNuTr1dFW4SzS/mg1UE9AsbJp6ucK17RapUbmSj6PBz5U7 83TQKeIeW9ttN/9M1qnzYeBcsMWmX6DINyPzMFcwTduH8zxY6Wp2kqNzK8voMMw= =3hBs -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--