From nobody Tue Mar 15 20:35:51 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C9D0A1A17A28 for ; Tue, 15 Mar 2022 20:36:00 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from smtp.burggraben.net (smtp.burggraben.net [IPv6:2a01:4f8:140:510a::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.burggraben.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KJ4tR5fdgz4sfm for ; Tue, 15 Mar 2022 20:35:59 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7120:1:127b:44ff:fe4f:148d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "elch.exwg.net", Issuer "R3" (not verified)) by smtp.burggraben.net (Postfix) with ESMTPS id D219CC00311 for ; Tue, 15 Mar 2022 21:35:51 +0100 (CET) Received: by elch.exwg.net (Postfix, from userid 1000) id 4F9193ADAC; Tue, 15 Mar 2022 21:35:51 +0100 (CET) Date: Tue, 15 Mar 2022 21:35:51 +0100 From: Christoph Moench-Tegeder To: freebsd-stable@freebsd.org Subject: Re: FreeBSD Errata Notice FreeBSD-EN-22:11.zfs Message-ID: Mail-Followup-To: freebsd-stable@freebsd.org References: <20220315192830.BA7F7454F@freefall.freebsd.org> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220315192830.BA7F7454F@freefall.freebsd.org> User-Agent: Mutt/2.2.1 (2022-02-19) X-Rspamd-Queue-Id: 4KJ4tR5fdgz4sfm X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of cmt@burggraben.net designates 2a01:4f8:140:510a::3 as permitted sender) smtp.mailfrom=cmt@burggraben.net X-Spamd-Result: default: False [-3.50 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[cmt]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:140:510a::3]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; DMARC_NA(0.00)[burggraben.net]; RCVD_IN_DNSWL_MED(-0.20)[2a01:4f8:140:510a::3:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-stable]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N ## FreeBSD Errata Notices (errata-notices@freebsd.org): > # fetch https://security.FreeBSD.org/patches/EN-22:11/zfs.patch Unless I'm totally cross-eyed, this patch is not what has been committed to releng/13.0 https://cgit.freebsd.org/src/commit/?h=releng/13.0&id=f5be20afc3568876c44269420a542627238e4da0 and the committed version does not compile (just bombed out here, so, yeah, confirmed). To be more precise, the newly added function vn_flush_cached_data() in sys/contrib/openzfs/include/os/freebsd/spl/sys/vnode.h is inside the '#ifndef IN_BASE' guard in zfs.patch but outside in releng/13.0. As it accesses vp->v_object (vp being a struct vnode *) and the #include of sys/vnode.h is inside a '#ifndef IN_BASE' guard in both the patch and the committed version, we don't have a full declaration of struct vnode in the committed variant of aforementioned file, so that vp->v_object must not be (at least as far as the C compiler is concerned). Regards, Christoph -- Spare Space