Date: Wed, 2 Feb 2005 13:27:46 -0500 (EST) From: Vivek Khera <vivek@khera.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/77028: net/jabber startup script not executable Message-ID: <20050202182746.9EF033ED6@lorax.kcilink.com> Resent-Message-ID: <200502021830.j12IUP2e007232@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 77028 >Category: ports >Synopsis: net/jabber startup script not executable >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 02 18:30:24 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Vivek Khera >Release: FreeBSD 4.10-RELEASE i386 >Organization: >Environment: System: FreeBSD lorax.kcilink.com 4.10-RELEASE FreeBSD 4.10-RELEASE #20: Fri May 28 14:13:44 EDT 2004 vivek@lorax.kcilink.com:/u/lorax1/usr/obj/u/lorax1/usr/src/sys/LORAX i386 >Description: I upgraded jabber from jabber-1.4.3.1 to jabber-1.4.3.1_1 and it left the rc.d/jabber.sh script non-executable. >How-To-Repeat: >Fix: install it executable :-) also, the RUNDIR is bad to put in /var/tmp since that might get cleaned up. jabber already is using /var/spool/jabber for its other data, so why not use that? this patch fixes this an also does a cleaner shutdown so you don't have to manually remove the pid file. of course you need to update your jabber.xml file to point the pidfile to the right place. /var/tmp is just wrong. --- jabberd.sh.dist Wed Feb 2 13:21:12 2005 +++ jabberd.sh Wed Feb 2 13:22:15 2005 @@ -6,7 +6,7 @@ fi USER="jabber" -RUNDIR="/var/tmp" +RUNDIR="/var/spool/jabber" HOSTNAME=`/bin/hostname` test -x ${PREFIX}/sbin/jabberd || exit 1 @@ -33,6 +33,5 @@ su -f -m ${USER} -c "jabberd -B -h ${HOSTNAME} -c ${PREFIX}/etc/jabber.xml" ;; stop) - killall -SIGKILL -u ${USER} jabberd; - rm -f ${RUNDIR}/jabber.pid; + kill `cat ${RUNDIR}/jabber.pid` esac >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050202182746.9EF033ED6>