From owner-svn-src-all@FreeBSD.ORG Fri Nov 9 19:23:03 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 540CE25A; Fri, 9 Nov 2012 19:23:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id E53288FC12; Fri, 9 Nov 2012 19:23:02 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qA9JMsMs067422; Fri, 9 Nov 2012 21:22:54 +0200 (EET) (envelope-from kostikbel@gmail.com) X-DKIM: OpenDKIM Filter v2.5.2 kib.kiev.ua qA9JMsMs067422 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qA9JMsGQ067421; Fri, 9 Nov 2012 21:22:54 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 9 Nov 2012 21:22:54 +0200 From: Konstantin Belousov To: Attilio Rao Subject: Re: svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/udf... Message-ID: <20121109192254.GH73505@kib.kiev.ua> References: <201211091802.qA9I2QP6026142@svn.freebsd.org> <20121109181103.GF73505@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/xzC8FKR3TvyAjXE" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2012 19:23:03 -0000 --/xzC8FKR3TvyAjXE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 09, 2012 at 06:50:52PM +0000, Attilio Rao wrote: > On Fri, Nov 9, 2012 at 6:47 PM, Attilio Rao wrote: > > On Fri, Nov 9, 2012 at 6:11 PM, Konstantin Belousov wrote: > >> On Fri, Nov 09, 2012 at 06:02:26PM +0000, Attilio Rao wrote: > >>> Author: attilio > >>> Date: Fri Nov 9 18:02:25 2012 > >>> New Revision: 242833 > >>> URL: http://svnweb.freebsd.org/changeset/base/242833 > >>> > >>> Log: > >>> Complete MPSAFE VFS interface and remove MNTK_MPSAFE flag. > >>> Porters should refer to __FreeBSD_version 1000021 for this change as > >>> it may have happened at the same timeframe. > >>> > >>> Modified: head/sys/fs/fuse/fuse_vfsops.c > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/sys/fs/fuse/fuse_vfsops.c Fri Nov 9 17:56:49 2012 = (r242832) > >>> +++ head/sys/fs/fuse/fuse_vfsops.c Fri Nov 9 18:02:25 2012 = (r242833) > >>> @@ -339,7 +339,6 @@ fuse_vfsop_mount(struct mount *mp) > >>> > >>> vfs_getnewfsid(mp); > >>> mp->mnt_flag |=3D MNT_LOCAL; > >>> - mp->mnt_kern_flag |=3D MNTK_MPSAFE; > >>> if (subtype) { > >>> strlcat(mp->mnt_stat.f_fstypename, ".", MFSNAMELEN); > >>> strlcat(mp->mnt_stat.f_fstypename, subtype, MFSNAMELEN); > >> > >> mnt_flag update should happen under the mount interlock. > > > > Yes I already have a patch for that, I'm waiting for testing by flo. >=20 > http://www.freebsd.org/~attilio/fuse_mnt_flag.patch Why mp->mnt_data and mp->mnt_stat.f_iosize updates are synchronized ? VFS does not modify them. --/xzC8FKR3TvyAjXE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCdWA0ACgkQC3+MBN1Mb4iYxQCcDdn67LUqowhwy4Ou4Fb7SUiC 21wAoKy5OWL6i517n622hcqBh+2gnMC7 =lZHx -----END PGP SIGNATURE----- --/xzC8FKR3TvyAjXE--