From owner-svn-src-all@FreeBSD.ORG  Sat Dec 17 21:54:28 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C1EC21065672;
	Sat, 17 Dec 2011 21:54:28 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 827038FC0A;
	Sat, 17 Dec 2011 21:54:28 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:34d8:b0a6:3463:89c2] (unknown
	[IPv6:2001:7b8:3a7:0:34d8:b0a6:3463:89c2])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id D60A45C37;
	Sat, 17 Dec 2011 22:54:27 +0100 (CET)
Message-ID: <4EED0F99.2020306@FreeBSD.org>
Date: Sat, 17 Dec 2011 22:54:33 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:9.0) Gecko/20111130 Thunderbird/9.0
MIME-Version: 1.0
To: mdf@FreeBSD.org
References: <201112171314.pBHDEjtQ060509@svn.freebsd.org>
	<CAMBSHm9cBbCxZ9MvgPvKgYfSxPSpeofgTq0NnJo=e3tR5idxEQ@mail.gmail.com>
In-Reply-To: <CAMBSHm9cBbCxZ9MvgPvKgYfSxPSpeofgTq0NnJo=e3tR5idxEQ@mail.gmail.com>
X-Enigmail-Version: 1.3.4
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r228625 - head/usr.bin/csup
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Dec 2011 21:54:28 -0000

On 2011-12-17 22:32, mdf@FreeBSD.org wrote:
...
>>  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the
>>  shared secret, and use long long format to snprintf a time_t.
> If casting is necessary, style prefers intmax_t or uintmax_t, since
> those are always wide enough.

I don't see anything about that in style(9), maybe it should be added
then?  In any case, I only changed the %ld format to %lld, because
time_t is int, long or long long depending on arch.  Long long is just
the widest type required in this case.