From owner-freebsd-ports  Wed Jun 25 03:15:25 1997
Return-Path: <owner-ports>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id DAA15059
          for ports-outgoing; Wed, 25 Jun 1997 03:15:25 -0700 (PDT)
Received: from beer.pilsnet.sunet.se (beer.pilsnet.sunet.se [192.36.125.73])
          by hub.freebsd.org (8.8.5/8.8.5) with SMTP id DAA15054
          for <ports@freebsd.org>; Wed, 25 Jun 1997 03:15:21 -0700 (PDT)
Received: from nbki.ipri.kiev.ua by beer.pilsnet.sunet.se (8.6.8/2.03)
	id MAA15155; Wed, 25 Jun 1997 12:14:52 +0200
Received: from cki.ipri.kiev.ua by nbki.ipri.kiev.ua with ESMTP id MAA10625;
  (8.6.9/zah/1.1) Wed, 25 Jun 1997 12:29:25 +0100
Received: from 194.44.146.14 (mac.ipri.kiev.ua [194.44.146.14]) by cki.ipri.kiev.ua (8.7.6/8.7.3) with SMTP id MAA00708; Wed, 25 Jun 1997 12:26:16 +0300 (EET DST)
Message-ID: <33B0D671.3A09@cki.ipri.kiev.ua>
Date: Wed, 25 Jun 1997 11:27:25 +0300
From: Ruslan Shevchenko <rssh@cki.ipri.kiev.ua>
Reply-To: rssh@cki.ipri.kiev.ua
Organization: IPRI
X-Mailer: Mozilla 3.01Gold (Macintosh; I; 68K)
MIME-Version: 1.0
To: itojun@itojun.org
CC: ports@freebsd.org
Subject: Re: about portlint
References: <33AE73AD.2C78@cki.ipri.kiev.ua> <18040.867082836@itojun.csl.sony.co.jp>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-ports@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

itojun@itojun.org wrote:
> 
> >> >+ one check:
> >> > in *_DEPENDS ${PORTSDIR}/foo/bar
> >> >      better then /usr/ports/foo/bar
> >> >(It is my coomon error;) )
> >>
> >>         Okey I will add it.  I should generalize this to check for:
> >>         - direct use of pathname /usr/local
> >>         - direct use of pathname /usr/X11R6
> >>         - direct use of pathname /usr/ports
> >>         in most places in the Makefile.
> >>         What else should we avoid?
> >absolute pathnames in scripts.
> 
>         how's this?
>         ftp://ftp.foretune.co.jp/pub/tools/portlint/portlint.pl-1.14

1. As I can understand, you chack pathname in
 PATHSITES, PATHFILES.

what if i have patch, living in directory

ftp.x.y/pub/usr/X11R6/lib/patch-for-foo ?

(of course, probability is low, but exists)

2. How about checkpathname in all files from 
  scripts/* (--optional, with WARH) ?


> 
> >(and flag for disable checking for some stupid
> >configuration scripts, as in SR)
> 
>         sorry to be dumb, what is referred to by SR?
> 

No, it's I sorry.

 It is my port: pr-3758.

You don't need to look at it, the matter, that the SR 
have own configure script, in which prefix must be parameter.

then, in configure i seen the code in next style:

  case $prefix in)
      /opt)
           .....
      /usr/opt)
           .......
      /usr/local)
           .......
      /usr/local/opt)
           ........
       ..........
       *)
          echo "can't configure'
          exit 1
  esac 

So, i *must* to write an absolute pathname.

So, I want future, such as:

### ---portlint, do not look at next line--- ###.
PREFIX=/usr/local

> itojun