From owner-svn-src-head@FreeBSD.ORG Sat Jun 13 11:30:38 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F0D58FF; Sat, 13 Jun 2015 11:30:37 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x230.google.com (mail-ob0-x230.google.com [IPv6:2607:f8b0:4003:c01::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B1FD433B; Sat, 13 Jun 2015 11:30:37 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by obbgp2 with SMTP id gp2so37344391obb.2; Sat, 13 Jun 2015 04:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=N4dsurT1CijUq6GeVEIi4nA/tN94ZmTuNyFFtDLLTkg=; b=zptzvAnifnWJhLgsK84BIO0t950F7UdYWina2F+uWoTczDC/HBzUXIuECylB8oJQLY 3MTUXjtE5sZdqw6sg5SEIdNY4aztjxfdFnz7FrduH1KOjsAzVxP4TWvVlsCH7VU7zt7v E4nVVfMPu9Tn/LdrIK5v5PpI/s66WSz3fISrxBXe60eihzkKlAOFkFde6Nef1TP2BlOZ 1tgZZ7nvklOIYvYnbpiFqdSAF06hbL46ASOmvCD0j+K4iwiLKMwSPw9fqx5grpZxMPdt 8WxAGq+TjORHrqJxIDiADXVrz/E+v+a/pu9U7jRM+qDQzH6Pqhk4dCn6WWz6K5M53UEk Mv8Q== MIME-Version: 1.0 X-Received: by 10.182.240.135 with SMTP id wa7mr2050624obc.63.1434195037036; Sat, 13 Jun 2015 04:30:37 -0700 (PDT) Received: by 10.202.69.70 with HTTP; Sat, 13 Jun 2015 04:30:36 -0700 (PDT) Received: by 10.202.69.70 with HTTP; Sat, 13 Jun 2015 04:30:36 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <201506130555.t5D5tQij003839@svn.freebsd.org> <20150613073746.GJ2080@kib.kiev.ua> Date: Sat, 13 Jun 2015 19:30:36 +0800 Message-ID: Subject: Re: svn commit: r284336 - head/sys/dev/acpi_support From: Marcelo Araujo To: Garrett Cooper Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, "src-committers@freebsd.org" , Allan Jude , Konstantin Belousov Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 11:30:38 -0000 +1. On Jun 13, 2015 3:42 PM, "NGie Cooper" wrote: > On Sat, Jun 13, 2015 at 12:37 AM, Konstantin Belousov > wrote: > > On Sat, Jun 13, 2015 at 05:55:26AM +0000, Allan Jude wrote: > >> Author: allanjude (doc committer) > >> Date: Sat Jun 13 05:55:26 2015 > >> New Revision: 284336 > >> URL: https://svnweb.freebsd.org/changeset/base/284336 > >> > >> Log: > >> acpi_ibm.ko panics if SMBIOS information is not available > >> > >> Add a check for NULL before strcmp on smbios information incase it is > not populated > >> > >> Differential Revision: https://reviews.freebsd.org/D2750 > >> Reviewed by: ngie, jhb > >> Approved by: rpaulo > >> Sponsored by: ScaleEngine Inc. > >> > >> Modified: > >> head/sys/dev/acpi_support/acpi_ibm.c > >> > >> Modified: head/sys/dev/acpi_support/acpi_ibm.c > >> > ============================================================================== > >> --- head/sys/dev/acpi_support/acpi_ibm.c Sat Jun 13 01:28:19 2015 > (r284335) > >> +++ head/sys/dev/acpi_support/acpi_ibm.c Sat Jun 13 05:55:26 2015 > (r284336) > >> @@ -485,6 +485,9 @@ acpi_ibm_attach(device_t dev) > >> /* Enable per-model events. */ > >> maker = kern_getenv("smbios.system.maker"); > >> product = kern_getenv("smbios.system.product"); > >> + if (maker != NULL && product != NULL) > >> + goto nosmbios; > > This looks reversed. I would expect the condition to be > > if (maker == NULL || product == NULL) > > goto ...; > > +1 > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >