From owner-svn-src-all@freebsd.org Thu May 28 09:25:09 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4231232BBA9; Thu, 28 May 2020 09:25:09 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49Xj3862sgz4GvD; Thu, 28 May 2020 09:25:08 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 3CB1C2601B1; Thu, 28 May 2020 11:25:01 +0200 (CEST) Subject: Re: svn commit: r361575 - head/sys/fs/nfsclient To: "Alexander V. Chernikov" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202005280735.04S7Z7R9049486@repo.freebsd.org> From: Hans Petter Selasky Message-ID: <3b651d92-be08-629c-7f53-049422f270ba@selasky.org> Date: Thu, 28 May 2020 11:24:46 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <202005280735.04S7Z7R9049486@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49Xj3862sgz4GvD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2020 09:25:09 -0000 On 2020-05-28 09:35, Alexander V. Chernikov wrote: > Author: melifaro > Date: Thu May 28 07:35:07 2020 > New Revision: 361575 > URL: https://svnweb.freebsd.org/changeset/base/361575 > > Log: > Make NFS address selection use fib4_lookup(). > > fib4_lookup_nh_ represents pre-epoch generation of fib api, > providing less guarantees over pointer validness and requiring > on-stack data copying. > Switch call to use new fib4_lookup(), allowing to eventually > deprecate old api. > > Differential Revision: https://reviews.freebsd.org/D24977 > > Modified: > head/sys/fs/nfsclient/nfs_clport.c > FYI: --- nfs_clport.o --- /usr/src/sys/fs/nfsclient/nfs_clport.c:974:6: error: unused variable 'error' [-Werror,-Wunused-variable] int error, fibnum; ^ 1 error generated. *** [nfs_clport.o] Error code 1 --HPS