Date: Wed, 24 Jun 2020 01:41:20 +0200 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r539975 - in head/x11-themes: . slim-freebsd-dark-theme Message-ID: <e64ab5c0-e339-1b6a-b55f-823a1bff22d3@FreeBSD.org> In-Reply-To: <CAP7rwciZVtXixHdn3nrOEWY3b%2BBzrVteuPKObyjNWPFcaxDVGw@mail.gmail.com> References: <202006231225.05NCPGsL001130@repo.freebsd.org> <CAP7rwchFe7qqiztufHM5E6U5bpFotz5O6DJB0RMS2couU=Sbdg@mail.gmail.com> <93fdbb58-3e28-3417-cd23-c07e168cd2f2@FreeBSD.org> <CAP7rwciZVtXixHdn3nrOEWY3b%2BBzrVteuPKObyjNWPFcaxDVGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/24/20 12:43 AM, Adam Weinberger wrote: > On Tue, Jun 23, 2020 at 4:40 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: >> On 6/24/20 12:12 AM, Adam Weinberger wrote: >>> On Tue, Jun 23, 2020 at 6:25 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: >>>> URL: https://svnweb.freebsd.org/changeset/ports/539975 >>>> >>>> Log: >>>> New port: x11-themes/slim-freebsd-dark-theme >> [...] >>> Shouldn't this port have a RUN_DEPENDS on x11/slim? >> I've checked similar ports and they do not depend on x11/slim. > Interesting. Should they? You know far more about the use-case here > than I do so I definitely defer to your judgment, but the description > makes it sound like x11/xlim is required to make it go. It is required, of course. It is a theme after all ;) I have a feeling that it would not help the end user to have RUN_DEPENDS here. In fact, I can imagine that new SLiM users might want to install a theme first, see if they like it based on the included screenshots, and then decide to download x11/slim. When it comes to old SLiM users, they have x11/slim installed anyway. Hmm, but the more I think about it, the more I feel it is not how we manage ports. We should at least have a SLIM option defined and then set SLIM_RUN_DEPENDS. But then who would really use it? Maybe we should just set RUN_DEPENDS=slim:x11/slim. Eh. What do you think, Adam? Cheers, Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e64ab5c0-e339-1b6a-b55f-823a1bff22d3>