From owner-cvs-all@FreeBSD.ORG  Thu Jun 14 06:48:08 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9C22116A46C
	for <cvs-all@freebsd.org>; Thu, 14 Jun 2007 06:48:08 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.228])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BB0F13C487
	for <cvs-all@freebsd.org>; Thu, 14 Jun 2007 06:48:08 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: by nz-out-0506.google.com with SMTP id 14so409158nzn
	for <cvs-all@freebsd.org>; Wed, 13 Jun 2007 23:48:07 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:reply-to:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=LtVKIJPB8mMspz5ctcC+mS6ewTCTL3kpHkI8AfYMI9nuDOMGAkEUCVwyMT7BMJ+Bjw8k+XZrHIL5i8DOFlppZzjoDEjhGpeF/imRZeAa/c+5GOqiuErUdzJ4KhBM0/rtIrlqjROsB/6n3izAPLMQPLOacyO0vqpEFETrwcSP9Iw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:reply-to:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=VWWVq0zjAN5kDhRGwEVL3gJKLTZZ3i1LIP9YAdJ/VksvA7UgOYYcKHLanShh8lWWC/FK0CcnsjReGuc36UjObT7u8QNAzXxodcx55mSQN5yZTiWVTi9uhaZ9b+Orvy/G3kaOFHj2l5Xdp0xLm1YNrUpxO1WmiCVic/qShrDwuPY=
Received: by 10.115.76.1 with SMTP id d1mr1484251wal.1181803687156;
	Wed, 13 Jun 2007 23:48:07 -0700 (PDT)
Received: by 10.114.194.13 with HTTP; Wed, 13 Jun 2007 23:48:07 -0700 (PDT)
Message-ID: <cb5206420706132348p21bb38u8f3688640f8e7f60@mail.gmail.com>
Date: Thu, 14 Jun 2007 10:48:07 +0400
From: "Andrew Pantyukhin" <sat@FreeBSD.org>
Sender: infofarmer@gmail.com
To: "Martin Wilke" <miwi@freebsd.org>, cvs-all@freebsd.org, 
	ports-committers@freebsd.org, "Bruce Cran" <bruce@cran.org.uk>
In-Reply-To: <20070614060727.1339516A566@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200706140607.l5E67NP5077264@repoman.freebsd.org>
	<20070614060727.1339516A566@hub.freebsd.org>
X-Google-Sender-Auth: 56ff2657f1997b18
Cc: 
Subject: Re: cvs commit: ports/sysutils/ataidle Makefile
	ports/sysutils/ataidle/files ataidle.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: infofarmer@FreeBSD.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2007 06:48:08 -0000

On 6/14/07, Martin Wilke <miwi@freebsd.org> wrote:
> miwi        2007-06-14 06:07:23 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     sysutils/ataidle     Makefile
>   Added files:
>     sysutils/ataidle/files ataidle.in
>   Log:
>   - Add rc.d script
>
>   PR:             113115
>   Submitted by:   Bruce Cran <bruce@cran.org.uk> (maintainer)
>
>   Revision  Changes    Path
>   1.10      +1 -0      ports/sysutils/ataidle/Makefile
>   1.1       +37 -0     ports/sysutils/ataidle/files/ataidle.in (new)
> _______________________________________________
> +name="ataidle"
> +rcvar=${name}_enable
> +command="%%LOCALBASE%%/sbin/${name}"

I assume you know how LOCALBASE differs from PREFIX
and which of the two should have been used here.

> +load_rc_config $name
> +
> +start_cmd="start_cmd"
> +start_cmd()
> +{
> +if [ -n "${ataidle_device}" ]; then
> +for i in ${ataidle_device}; do
> +eval ataidle_args=\$ataidle_${i}
> +${command} ${ataidle_args}
> +done
> +fi
> +
> +}

What's with the indentation? Also there's no
newline at end of file, which would be fixed
if you opened it in almost any editor and saved
without changes.