Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jun 2007 10:48:07 +0400
From:      "Andrew Pantyukhin" <sat@FreeBSD.org>
To:        "Martin Wilke" <miwi@freebsd.org>, cvs-all@freebsd.org,  ports-committers@freebsd.org, "Bruce Cran" <bruce@cran.org.uk>
Subject:   Re: cvs commit: ports/sysutils/ataidle Makefile ports/sysutils/ataidle/files ataidle.in
Message-ID:  <cb5206420706132348p21bb38u8f3688640f8e7f60@mail.gmail.com>
In-Reply-To: <20070614060727.1339516A566@hub.freebsd.org>
References:  <200706140607.l5E67NP5077264@repoman.freebsd.org> <20070614060727.1339516A566@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6/14/07, Martin Wilke <miwi@freebsd.org> wrote:
> miwi        2007-06-14 06:07:23 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     sysutils/ataidle     Makefile
>   Added files:
>     sysutils/ataidle/files ataidle.in
>   Log:
>   - Add rc.d script
>
>   PR:             113115
>   Submitted by:   Bruce Cran <bruce@cran.org.uk> (maintainer)
>
>   Revision  Changes    Path
>   1.10      +1 -0      ports/sysutils/ataidle/Makefile
>   1.1       +37 -0     ports/sysutils/ataidle/files/ataidle.in (new)
> _______________________________________________
> +name="ataidle"
> +rcvar=${name}_enable
> +command="%%LOCALBASE%%/sbin/${name}"

I assume you know how LOCALBASE differs from PREFIX
and which of the two should have been used here.

> +load_rc_config $name
> +
> +start_cmd="start_cmd"
> +start_cmd()
> +{
> +if [ -n "${ataidle_device}" ]; then
> +for i in ${ataidle_device}; do
> +eval ataidle_args=\$ataidle_${i}
> +${command} ${ataidle_args}
> +done
> +fi
> +
> +}

What's with the indentation? Also there's no
newline at end of file, which would be fixed
if you opened it in almost any editor and saved
without changes.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420706132348p21bb38u8f3688640f8e7f60>