From owner-cvs-all Fri Jul 21 7: 4:36 2000 Delivered-To: cvs-all@freebsd.org Received: from whizzo.transsys.com (whizzo.TransSys.COM [144.202.42.10]) by hub.freebsd.org (Postfix) with ESMTP id D416C37BAF7; Fri, 21 Jul 2000 07:04:19 -0700 (PDT) (envelope-from louie@whizzo.transsys.com) Received: from whizzo.transsys.com (localhost.transsys.com [127.0.0.1]) by whizzo.transsys.com (8.9.3/8.9.1) with ESMTP id KAA53922; Fri, 21 Jul 2000 10:04:00 -0400 (EDT) (envelope-from louie@whizzo.transsys.com) Message-Id: <200007211404.KAA53922@whizzo.transsys.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: "Jordan K. Hubbard" Cc: Brian Somers , Jordan Hubbard , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Brian Somers , shin@FreeBSD.ORG X-Image-URL: http://www.transsys.com/louie/images/louie-mail.jpg From: "Louis A. Mamakos" Subject: Re: cvs commit: src/lib/libc/net rcmd.3 rcmd.c References: <695.964160550@localhost> In-reply-to: Your message of "Thu, 20 Jul 2000 23:22:30 PDT." <695.964160550@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 21 Jul 2000 10:04:00 -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Shouldn't these interfaces to a grossly insecure mechanism be depricated rather than improved? louie > Seems like one to me. > > - Jordan > > > I think this is a MFC candidate... comments ? > > > > > brian 2000/07/20 02:05:15 PDT > > > > > > Modified files: > > > lib/libc/net rcmd.3 rcmd.c > > > Log: > > > Alocate rcmd{,_af}()'s *ahost argument using malloc() (well > > > strdup()) rather than pointing it at something that's free()d > > > (via freeaddrinfo(res)) before the function returns. > > > > > > I appreciate that this is an API change, but it's the only way > > > (AFAIK) of doing this without breaking existing code that uses > > > rcmd{,_af}(). > > > > > > Pointed out by: phkmalloc > > > > > > Revision Changes Path > > > 1.15 +6 -1 src/lib/libc/net/rcmd.3 > > > 1.27 +10 -4 src/lib/libc/net/rcmd.c > > > > > > > > > > > > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message