From owner-freebsd-eclipse@FreeBSD.ORG Wed Aug 27 00:47:23 2008 Return-Path: Delivered-To: freebsd-eclipse@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D92C5106566B for ; Wed, 27 Aug 2008 00:47:23 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id 18AC88FC19 for ; Wed, 27 Aug 2008 00:47:22 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.14.2/8.14.2) with ESMTP id m7R0Z9Zc047125; Tue, 26 Aug 2008 17:35:10 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.14.2/8.14.2/Submit) id m7R0Z9Ia047124; Tue, 26 Aug 2008 17:35:09 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Tue, 26 Aug 2008 17:35:08 -0700 From: Greg Lewis To: "Rick C. Petty" Message-ID: <20080827003508.GA39878@misty.eyesbeyond.com> References: <20080826191341.GA37568@keira.kiwi-computer.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080826191341.GA37568@keira.kiwi-computer.com> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-eclipse@freebsd.org Subject: Re: wrong JAVA_VENDOR X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2008 00:47:23 -0000 On Tue, Aug 26, 2008 at 02:13:41PM -0500, Rick C. Petty wrote: > If you install java/diablo-jdk16 instead of java/jdk16, the JAVA_VENDOR is > "freebsd". The java/eclipse Makefile sets JAVA_VENDOR to "bsdjava". Why > is this? This makes it so that you cannot run eclipse with only > diablo-jdk16 installed. Why is it even being set? Isn't it enough that we > use JAVA_OS=native ??? I suggest the following patch: This is because people would install diablo-jdk15 on FreeBSD 7.x. This will run Java programmes if you have compat6x installed and some libmap entries set up, but it won't run Eclipse. Now that we have diablo-jdk16 which has a native 7.x version we could change 700000 to 800000, but the risk is that people on 7.x with diablo-jdk15 already installed will then be able to install with it guaranteed to break. I'll try an alternative change. > --- ports/java/eclipse/Makefile.orig 2008-08-14 19:17:21.000000000 -0500 > +++ ports/java/eclipse/Makefile 2008-08-26 19:13:03.000000000 -0500 > @@ -60,10 +60,6 @@ > > .include > > -.if ${OSVERSION} >= 700000 > -JAVA_VENDOR= bsdjava > -.endif > - > .if !defined(WITHOUT_MOZILLA) > MAKE_MOZILLA= make_mozilla > BROWSER= ${GECKO} > > > -- Rick C. Petty > _______________________________________________ > freebsd-eclipse@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse > To unsubscribe, send any mail to "freebsd-eclipse-unsubscribe@freebsd.org" -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org