From owner-svn-src-all@FreeBSD.ORG Fri Apr 22 07:50:00 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A801106566C; Fri, 22 Apr 2011 07:50:00 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi [195.197.172.116]) by mx1.freebsd.org (Postfix) with ESMTP id 425238FC0C; Fri, 22 Apr 2011 07:50:00 +0000 (UTC) Received: from a91-153-123-205.elisa-laajakaista.fi (a91-153-123-205.elisa-laajakaista.fi [91.153.123.205]) by gw02.mail.saunalahti.fi (Postfix) with SMTP id 7496713984F; Fri, 22 Apr 2011 10:49:54 +0300 (EEST) Date: Fri, 22 Apr 2011 10:49:54 +0300 From: Jaakko Heinonen To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <20110422074953.GA53521@a91-153-123-205.elisa-laajakaista.fi> References: <201104220726.p3M7Q9pZ031647@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201104220726.p3M7Q9pZ031647@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: jamie@FreeBSD.org Subject: Re: svn commit: r220937 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2011 07:50:00 -0000 (jamie@ Cc'd because kern_jail.c also uses the vfsopt framework.) On 2011-04-22, Jaakko Heinonen wrote: > + * XXX: This function will keep a "nofoo" option in the new > + * options. E.g, if the option's canonical name is "foo", > + * "nofoo" ends up in the mount point's active options. I have a follow-up patch which adds a flags field to the vfsopt struct and changes vfs_filteropt() to mark options which should not become active but only cancel other options with a flag. This allows vfs_mergeopts() to know which options should be made active. With these changes we can remove the "foo" -> "nonofoo" conversions from vfs_donmount() for options whose canonical name starts with "no". The patch: http://people.freebsd.org/~jh/patches/nmount-VFSOPT_CANCELONLY.diff -- Jaakko