From owner-cvs-all  Thu Jan 16 14: 1:15 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C7D4237B401; Thu, 16 Jan 2003 14:01:14 -0800 (PST)
Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 46DA243E4A; Thu, 16 Jan 2003 14:01:14 -0800 (PST)
	(envelope-from gibbs@scsiguy.com)
Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11])
	by magic.adaptec.com (8.11.6+Sun/8.11.6) with ESMTP id h0GM0dj03996;
	Thu, 16 Jan 2003 14:00:39 -0800 (PST)
Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [10.100.0.52])
	by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id OAA01091;
	Thu, 16 Jan 2003 14:00:38 -0800 (PST)
Received: from [10.100.253.70] (aslan [10.100.253.70])
	by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id PAA18603;
	Thu, 16 Jan 2003 15:00:35 -0700 (MST)
Date: Thu, 16 Jan 2003 15:00:36 -0700
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
Reply-To: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: Nate Lawson <nate@root.org>,
	Hidetoshi Shimokawa <simokawa@freebsd.org>
Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c         fwohcivar.h
Message-ID: <621240000.1042754436@aslan.btc.adaptec.com>
In-Reply-To: <Pine.BSF.4.21.0301161007080.46845-100000@root.org>
References:  <Pine.BSF.4.21.0301161007080.46845-100000@root.org>
X-Mailer: Mulberry/3.0.0b10 (Linux/x86)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

>>   Modified files:
>>     sys/dev/firewire     firewire.c fwdev.c fwohci.c fwohcivar.h 
>>   Log:
>>   Improve memory allocation.
>>   - Don't use contigmalloc() and allocate page by page to avoid
>>           allocation failure.
>>   - allocate buffer by PAGE_SIZE.
> 
> Some comments.
> 
>> -		contigfree((void *)(uintptr_t)sc->fc.sid_buf,
>> -					OHCI_SIDSIZE, M_DEVBUF);
>> +		free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF);

malloced buffers are not guaranteed to be accessable by a device.
Use bus dma instead.

--
Justin


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message