From nobody Thu Jul 9 02:54:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gwfgS63Rvz6kLkG for ; Thu, 09 Jul 2026 02:54:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gwfgS4lFJz3xT9 for ; Thu, 09 Jul 2026 02:54:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783565652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QDhT1X5469q6ngsT5tdL48N+4uKztYJPctsacxm5H6M=; b=ySkK/G9bd5cr8DNkSRCdk6/TI5p/m83f101c/jIx68vvHZU0+gwtYYtPXAoSVT8+dJsdME IXYyGIUKeqoS5y9r5vV1nsIFDnlXqoWVrHIL9+E1DliA8fsCltADhzeMIlqG1ofvNDEuIA U437QTTBsrs9vc8xftG+Ng5P47yEJk/hOBVioSJJlBph0sDjtz5cnbXG8ZLUOj3K/6Cl06 n7VlNzl/FP9jwH3ZcSw7YosLSktRgXLW4tJxOwX/KMhqt3uSoaFrvOyMxCoyFkwdk8faTT lL7xRzJ5HWWhrnTVm9bDjSO3tOa+XQVCzQ/zP3510TdsiCfe8qP+1Xhjeag7Bg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783565652; a=rsa-sha256; cv=none; b=KAEP7ht5b5z9LgNwoqCSW7uwL7IpjG1o0NcxXWEaTeUK0cjjKBkUS7nePngED7wMi+03S9 qaxlNOcJEk6REGLK9MOnnLNL0gQ2BEf+GVY6EAbU0TXZ+Mfw2NsYfuovBLTcrPa9dPuqrY 1mRkUhb4wNV9XVSA6juwZJu2LeTNmKA+JJ5cFCtsr3t01eRtHo9yqzpoT7OHjjmp1Vgg4O qaRltEgeoHPQBUvznQ6L12TRmVxV+TWvI94h+KEqh1Mp9EYOsMw2iyvN+js0wl8viLcED/ Eb2o/Z5gzofQvkiNcYnqpmwgeDmFZzk+Wgc6hqQjeEeIlF30pc5VgPGDtsg1Kw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783565652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QDhT1X5469q6ngsT5tdL48N+4uKztYJPctsacxm5H6M=; b=B1u2btPDn0CRbWwtQTxAbW27Ak7zhvSPEZKy3uGqaJE33aO8OI1SlAqufEPrHchG8PEyVD 405Lh6YQavOQcg3hz6XSMRW6e8fptIhffQPJzgD82IFp2WAnbvtgfhA77aDyNRfpzUsYje r/RsxA2j0brJqgpA9nW5pVSPeeHpzYuoV4iYPzahrrwCVjnVOBRgZfz4yK8stSkhxQdCqq EmZRqUBDWj9gTcBls2yaMp7Hcjhm1s+Ze9gsxPCoJxUGpOdYuPOLwOGbTaWjPxIO3JNV4O bhqsw/UWHT2WysMOpZO1DQcFa+Lgv3hpbOcie4CYzL77gQ5jDbDV30qmvOwRHg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gwfgS3fdVzqSB for ; Thu, 09 Jul 2026 02:54:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21b3a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 09 Jul 2026 02:54:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Adrian Chadd Subject: git: d128ddf32e87 - main - fwcam: retry ISO enable after re-powering camera List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d128ddf32e87a672dbbbc26cfece71e241e0ffa0 Auto-Submitted: auto-generated Date: Thu, 09 Jul 2026 02:54:12 +0000 Message-Id: <6a4f0d54.21b3a.4d230ce9@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=d128ddf32e87a672dbbbc26cfece71e241e0ffa0 commit d128ddf32e87a672dbbbc26cfece71e241e0ffa0 Author: Abdelkader Boudih AuthorDate: 2026-07-09 02:52:29 +0000 Commit: Adrian Chadd CommitDate: 2026-07-09 02:52:30 +0000 fwcam: retry ISO enable after re-powering camera Some IIDC cameras power down the sensor when inactive (e.g. lens cover closed) and reject ISO enable with EIO. Re-power the camera and retry once before failing. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D58101 --- sys/dev/firewire/fwcam.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/sys/dev/firewire/fwcam.c b/sys/dev/firewire/fwcam.c index c5e5cf545fe9..234dd41eedf1 100644 --- a/sys/dev/firewire/fwcam.c +++ b/sys/dev/firewire/fwcam.c @@ -429,7 +429,22 @@ fwcam_iso_start(struct fwcam_softc *sc) } err = fwcam_write_quadlet(sc, IIDC_ISO_EN, IIDC_ISO_EN_ON); - if (err) { + if (err == EIO) { + /* + * Cameras with a lens cover might power down the sensor + * when the cover is closed and reject streaming requests. + * Try to re-power and retry once before giving up. + */ + err = fwcam_power_on(sc); + if (err == 0) + err = fwcam_write_quadlet(sc, IIDC_ISO_EN, + IIDC_ISO_EN_ON); + if (err) { + device_printf(sc->fd.dev, + "ISO enable refused (lens cover closed?)\n"); + goto fail; + } + } else if (err) { device_printf(sc->fd.dev, "failed to enable ISO: %d\n", err); goto fail;