From owner-svn-src-all@freebsd.org Thu Jun 14 03:31:17 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5EF3F101956B for ; Thu, 14 Jun 2018 03:31:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E48A76EE08 for ; Thu, 14 Jun 2018 03:31:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id k3-v6so5726052iog.3 for ; Wed, 13 Jun 2018 20:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ysTQO6zgCkJBaeakKDfHmhYHx2y+pzGGdRUZ2zfEdKw=; b=CNC4totR/Mf7KFwILXZfs7j04S7VCyxPYWcKRu2kG2fuj3VFYAMTdkVbMrdsNRchC+ YDH3SJMl3PaiyBKqdwYUgq9vxTE6laHbNnyqCcA6xZsjoNcgq6pHYkeLzB3585NzE2l8 ixppn8mKdVZU3vASA8qGQmFFHzF6/2IcwXYEk0pFJhLpCvs2Y9wZ2DGSeDOdTXfi5Hpx dT/dGgwY49NHnkiNGxMEzCHDq5cLKmRYaXiLFKQzmI7Wrglm3mXOah5NNG4MvJi6x6Nn 9EObFqnbW9pDlhD24iz5ag+F0QUls1wTV9iJWdRd0qL1Mg2FFqCsxzPRLzOS4qgUFWp5 Mdxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ysTQO6zgCkJBaeakKDfHmhYHx2y+pzGGdRUZ2zfEdKw=; b=Hj9zZPW8zpg6ln2fCpoCafoVm4tmL1EK+PApvbMcA2VOsggkIGNLYnrx7LDJd4bJc5 nOMk/w7ZUJMTgHekvqpg2KiHo7k24jrF4dBPp+5V29qMONNWGA+DBGUc5uUV3SkNzGYv LZHxScZ1diApqlunqaadCRpF7k8SbYatYqKjiBovqrcJT+aQCCVVhWgOEH1rcdo3zG7b 36kF0h46PYV3IxmsHMYx5tRTLL0808WANer8y3+fEj3j6lLgQlLU6L77J8kpLWv6/8WM TAMxR/S+jdSmdJH/N61AVGLjXdjwmBjZOx4wEsnN1/32BuFNGxUDmffvso8dxuymZ/q1 31IQ== X-Gm-Message-State: APt69E0upssGgD3pheUYUGFlSddYqU83ajdjNQy6+Gkrd8g9Scd73Hoy znvCPQ0h0Q/ZyvTtcrJKRFrGZ+DsD6GmTdqktRbYVg== X-Google-Smtp-Source: ADUXVKIUhLVnFu5LaZwIX1ktKXJAyO7aIaEpl7E9XZHCu91+0UrLFO0dyHA5LTpasgHGGcDLGnyyr2r+OuW4kbwufQ4= X-Received: by 2002:a6b:29c4:: with SMTP id p187-v6mr685944iop.299.1528947076260; Wed, 13 Jun 2018 20:31:16 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 20:31:15 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201806140328.w5E3SCZp042620@pdx.rh.CN85.dnsmgr.net> References: <201806140328.w5E3SCZp042620@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 13 Jun 2018 21:31:15 -0600 X-Google-Sender-Auth: ppY4Ormpjdlm2QG_b-lSgX5kfHw Message-ID: Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 03:31:17 -0000 Ah, that's what you were talking about. OK. Will do. Warner On Wed, Jun 13, 2018 at 9:28 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > Author: imp > > > > Date: Wed Jun 13 22:00:02 2018 > > > > New Revision: 335091 > > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > > > > > Log: > > > > Make it possible to use print_controller from another program > > > > > > > > Rename print_controller to nvme_print_controller. Put it in its > > > > own file for easy inclusion. Move util.c to be nc_util.c to not > > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > > > interfaces. > > > > > > > > Sponsored by: Netflix > > > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > > > > > Added: > > > > head/sbin/nvmecontrol/identify_ext.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/ > identify.c > > > > head/sbin/nvmecontrol/nc_util.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > changed) > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > ... > > > > > > > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > > > r335089, head/sbin/nvmecontrol/util.c) > > > > ============================================================ > > > ================== > > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > > > (r335089, copy source) > > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > 2018 > > > (r335091) > > > > @@ -1,7 +1,8 @@ > > > > /*- > > > > - * Copyright (c) 2017 Netflix, Inc > > > > - * All rights reserved. > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > > * > > > > + * Copyright (C) 2018 Netflix > > > > > > You moved a copyright forward, that is not proper to do. > > > > > > > Thought it was. I honestly don't care where (nor does my employer), so if > > you want to tweak it to be more conforming, be my guest. > > You can add a new date to the end of a list, but you should always > retain the oldest date, and many opinions are that all dates should > be retained unless they are continuous. > > It would be much simpler for you to commit: > - * Copyright (C) 2018 Netflix > + * Copyright (C) 2017-2018 Netflix > > Than for me to get approval: bde, phk. > > Thanks. > Rod > > > > > > Not sure about dropping the , Inc either. > > > > > > Doesn't matter. Different Netflix committers do different things and I > was > > trying to move towards uniformity. > > Ok > > > Warner > > -- > Rod Grimes > rgrimes@freebsd.org >