From owner-freebsd-rc@FreeBSD.ORG Tue Jul 3 16:07:59 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AEDA716A41F for ; Tue, 3 Jul 2007 16:07:59 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 5A5DC13C447 for ; Tue, 3 Jul 2007 16:07:59 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l63FVePP017377; Tue, 3 Jul 2007 10:31:40 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l63FVeLH017376; Tue, 3 Jul 2007 10:31:40 -0500 (CDT) (envelope-from brooks) Date: Tue, 3 Jul 2007 10:31:40 -0500 From: Brooks Davis To: Max Laier Message-ID: <20070703153140.GA17065@lor.one-eyed-alien.net> References: <200707031616.29564.max@love2party.net> <468A5DB2.50504@delphij.net> <200707031642.44635.max@love2party.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: <200707031642.44635.max@love2party.net> User-Agent: Mutt/1.5.15 (2007-04-06) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Tue, 03 Jul 2007 10:31:41 -0500 (CDT) Cc: freebsd-rc@freebsd.org, Xin LI Subject: Re: ftp-proxy X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2007 16:07:59 -0000 --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 03, 2007 at 04:42:38PM +0200, Max Laier wrote: > On Tuesday 03 July 2007, Xin LI wrote: > > Max Laier wrote: > > > Hi, > > > > > > does the attached startup script for ftp-proxy(8) look reasonable?=20 > > > Please keep me in CC as I'm not on the list, thanks. > > > > I think you missed the attachment :-) >=20 > strange - might be the list sanity checks again? I did send it for sure.= =20 > Anyways, here we go again: >=20 > Index: defaults/rc.conf > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /usr/store/mlaier/fcvs/src/etc/defaults/rc.conf,v > retrieving revision 1.316 > diff -u -r1.316 rc.conf > --- defaults/rc.conf 12 Jun 2007 17:33:23 -0000 1.316 > +++ defaults/rc.conf 3 Jul 2007 14:12:58 -0000 > @@ -154,6 +154,8 @@ > pflog_logfile=3D"/var/log/pflog" # where pflogd should store the logfile > pflog_program=3D"/sbin/pflogd" # where the pflogd program lives > pflog_flags=3D"" # additional flags for pflogd > +ftpproxy_enable=3D"NO" # Set to YES to enable ftp-proxy(8) for pf > +ftpproxy_flags=3D"" # additional flags for ftp-proxy(8) > pfsync_enable=3D"NO" # Expose pf state to other hosts for syncing > pfsync_syncdev=3D"" # Interface for pfsync to work through > pfsync_syncpeer=3D"" # IP address of pfsync peer host > Index: rc.d/ftp-proxy > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: rc.d/ftp-proxy > diff -N rc.d/ftp-proxy > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ rc.d/ftp-proxy 3 Jul 2007 14:11:26 -0000 > @@ -0,0 +1,17 @@ > +#!/bin/sh > +# > +# $FreeBSD$ > +# > + > +# PROVIDE: ftp-proxy > +# REQUIRE: DAEMON pf It seems like there should be a shutdown keyword here, though for some reason we don't include them in lots of things we could stop at shutdown so I may be wrong. > +# > + > +. /etc/rc.subr > + > +name=3D"ftpproxy" > +rcvar=3D`set_rcvar` > +command=3D"/usr/sbin/ftp-proxy" > + > +load_rc_-config $name There's a stray '-' in there. > +run_rc_command "$1" -- Brooks --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGimvbXY6L6fI4GtQRAgUZAJ9NMrj1nIqLNPn13RqT/C1FJx5TMwCfbwXj yBlhj4j62FpY8HZaOvAcFv0= =r6rn -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI--