From nobody Fri Feb 4 23:01:46 2022 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9FABF198D3ED for ; Fri, 4 Feb 2022 23:01:58 +0000 (UTC) (envelope-from SRS0=3mPw=ST=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jr9ys64G0z4V0d for ; Fri, 4 Feb 2022 23:01:57 +0000 (UTC) (envelope-from SRS0=3mPw=ST=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id D352128417; Sat, 5 Feb 2022 00:01:49 +0100 (CET) Received: from illbsd.quip.test (ip-78-45-215-131.net.upcbroadband.cz [78.45.215.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 363DF28411; Sat, 5 Feb 2022 00:01:48 +0100 (CET) Subject: Re: php-fpm (8.0) strange error related to smbclient To: Xavier Humbert , ports@freebsd.org References: <121050fe-6243-5ec2-3922-8e4c8a7ef936@groumpf.org> From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: Date: Sat, 5 Feb 2022 00:01:46 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 In-Reply-To: <121050fe-6243-5ec2-3922-8e4c8a7ef936@groumpf.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Jr9ys64G0z4V0d X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of "SRS0=3mPw=ST=quip.cz=000.fbsd@elsa.codelab.cz" has no SPF policy when checking 94.124.105.4) smtp.mailfrom="SRS0=3mPw=ST=quip.cz=000.fbsd@elsa.codelab.cz" X-Spamd-Result: default: False [2.23 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[quip.cz]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[0.997]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.963]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(1.00)[1.000]; MLMMJ_DEST(0.00)[ports]; FORGED_SENDER(0.30)[000.fbsd@quip.cz,SRS0=3mPw=ST=quip.cz=000.fbsd@elsa.codelab.cz]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[000.fbsd@quip.cz,SRS0=3mPw=ST=quip.cz=000.fbsd@elsa.codelab.cz]; RECEIVED_SPAMHAUS_PBL(0.00)[78.45.215.131:received] X-ThisMailContainsUnwantedMimeParts: N On 04/02/2022 21:20, Xavier Humbert wrote: > Hi, > > I recently upgraded my whole php stuff from 7.3 to 8.0 via portupgrade > > All went flawlessly. But when I want to start php-fpm, I got this error > about which Google knows nothing : > >> [root@numenor php80]# service php-fpm restart >> Performing sanity check on php-fpm configuration: >>
>> Fatal error:  Duplicate parameter name $oldstate for function >> smbclient_rename() in Unknown on line 0
> I eventually grepped the whole /usr/local/etc AND /usr/local/www > directories for this parameter with no success > > Where the hell does this come from ? Samba, obviously, a grep in > /usr/local/lib/php matches in smbclient.so > > Also, libsbmclient-php sources show this parameter twice : > https://github.com/eduardok/libsmbclient-php/blob/master/smbclient.c#L189 > > But how fix this, any idea May I fill a PR ? This is just a wild guess but I thing there is something wrong with your pecl-smbclient extension. The Fatal error is from loading this extension at the start of php-fpm and not from calling some function in any PHP script. There is a source code where it is really twice oldstate and twice oldpath https://github.com/eduardok/libsmbclient-php/blob/master/smbclient.c#L189 ZEND_BEGIN_ARG_INFO(arginfo_smbclient_rename, 0) ZEND_ARG_INFO(0, oldstate) ZEND_ARG_INFO(0, oldpath) ZEND_ARG_INFO(0, oldstate) ZEND_ARG_INFO(0, oldpath) ZEND_END_ARG_INFO() I am not a C programmer but it seems wrong to me, because PHP function smbclient_rename takes 4 different parameters: smbclient_rename ( resource $state_old, string $uri_old, resource $state_new, string $uri_new ) I will expect something like this: ZEND_BEGIN_ARG_INFO(arginfo_smbclient_rename, 0) ZEND_ARG_INFO(0, oldstate) ZEND_ARG_INFO(0, oldpath) ZEND_ARG_INFO(0, newstate) ZEND_ARG_INFO(0, newpath) ZEND_END_ARG_INFO() But I don't know if this will fix it or destroy the whole universe. Miroslav Lachman