From nobody Tue Jun 30 17:19:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gqVHs6XMKz6jXdR for ; Tue, 30 Jun 2026 17:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gqVHs2yy9z3nmc for ; Tue, 30 Jun 2026 17:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782839961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eBZWzpKGIdMGcr3qoSmqjraqayijNOuqjZ/Cji7i4o8=; b=MUJe6xqgUHujj+GLiOxbaCqZXQ9xZ1Y0FUDBnrY1GFA/jME4uMeSWONY8rE+R6YIRR4kXb YxS9PyEL7lClKh7fLujEzTmbNmZ8CZgB+my5aSyBIHyMaqjaAbKDPoxQ3gNkazhk7gZab4 Xyoj8iuXWAjh0DFhFjnx8Gmu7VfxvgW/vVws0hUqKPGtWZcGqdMd6QFd2k+QchK1kv99aX 47fE+Kd3DnVmKMx6Ja8aJJoY41/EOEC710xbhJZPjvjnQWVoocwUcNHOlUbcg8OMMxo2mg 7iGERbyDFsKEj+ThbXxu+erkZCZ2kurgYG2qbW/FvgVENK4TBILW7POf5taHCg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782839961; a=rsa-sha256; cv=none; b=dVTy6PHKx0tolOLoqxtk74KtdPM4kdNcByy6iATrcK5g0DigyGcLK4w/ovEp4Noxjv8OM7 Q716EXgVFpWUUd6+3zn8CD+H8PvvPSSQfBEpdT1qv7w6c0gzz9eNWN2EHLam9UlrRKoDfW 2TA1uD1znGtEqDMJaG8w8xELNq8W3HpyRUcxulBcW5eZvFec8UCjv6De1IFbZeivNZKREl 4qcjVaxZ8UE8psOYHoO07rg0wlFOv9XkbjirCbV7zBltoheWiBqX3+v55im6iOKIN0E2rG ydMC8ugAjUhCWeSXWuI33hD/DvcPOde+AHvucKhYdwk8K9jkwoo7L+Fr2AEXGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782839961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eBZWzpKGIdMGcr3qoSmqjraqayijNOuqjZ/Cji7i4o8=; b=vdjZvYHsH1SPOXMcai+Sz0TPIkuMRxjgVnH0hv8E9w9EHQBZ7hm93466I1z2y18TB6h1SQ Pvpm2JTGKcwyMQsBnpeCjKvS0q0G9KRuuzTlaF8eCKksWM+cZncseKeA0/Oj6rgoPdB7Tr ryIhzN20kWtlQx/fP/gmP2tYw+eauqqz0UAt6qr+6lqArXX4qlFCDHNP3luDqFnkaYOPHx iz6mCLqp2UlBzw2mP6FXCwALg2BhPYNjIUvPti9WvgMvGdQ+8czPgZEuP1v4akiZDlW1W/ R5WPpjNdkVQfTlRsGa03TtGKHg5hzZTgztas21kQB0FtewVAcxMKQy99SsOeYQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gqVHs1r1sztTy for ; Tue, 30 Jun 2026 17:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44807 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 30 Jun 2026 17:19:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 150df709c28c - main - iconv: Fix a stack buffer overflow in _ISO2022_sputwchar() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 150df709c28ca10a7ccec02482441257ec9c13da Auto-Submitted: auto-generated Date: Tue, 30 Jun 2026 17:19:21 +0000 Message-Id: <6a43fa99.44807.210e8af5@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=150df709c28ca10a7ccec02482441257ec9c13da commit 150df709c28ca10a7ccec02482441257ec9c13da Author: Mark Johnston AuthorDate: 2026-06-23 17:45:28 +0000 Commit: Mark Johnston CommitDate: 2026-06-30 17:00:23 +0000 iconv: Fix a stack buffer overflow in _ISO2022_sputwchar() In the ISO2022-CN encoding, characters may require at least seven bytes, and MB_LEN_MAX==6 is insufficient. From code inspection, _ISO2022_sputwchar() can emit 10 bytes in the worst case, so use that to size buffers. Add a regression test. Approved by: so Security: FreeBSD-SA-26:49.iconv Security: CVE-2026-58082 Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D57950 --- contrib/netbsd-tests/lib/libc/locale/t_iconv.c | 20 ++++++++++++++++++++ lib/libiconv_modules/ISO2022/citrus_iso2022.c | 8 ++++---- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/contrib/netbsd-tests/lib/libc/locale/t_iconv.c b/contrib/netbsd-tests/lib/libc/locale/t_iconv.c index f5667cf20e80..c6cd7d181c03 100644 --- a/contrib/netbsd-tests/lib/libc/locale/t_iconv.c +++ b/contrib/netbsd-tests/lib/libc/locale/t_iconv.c @@ -117,6 +117,26 @@ static const struct sample { 0x82,0x42,0x79,0x65, 0x2e }, 0, 0, NULL }, + /* 馬 from CNS 11643-1 */ + [9] = { "UTF-8", 3, (const char[3]){0xe9,0xa6,0xac}, + "ISO-2022-CN", 8, + (const char[8]){0x1b,0x24,0x29,0x47,0x0e,0x58,0x6b,0x0f}, + 0, 0, NULL }, + /* 馬毦 shifting from CNS 11643-1 to CNS 11643-2 */ + [10] = { "UTF-8", 6, (const char[6]){0xe9,0xa6,0xac,0xe6,0xaf,0xa6}, + "ISO-2022-CN", 16, + (const char[16]){ + /* ESC $ ) G (shift G1 to CNS 11643 plane 1) */ + 0x1b,0x24,0x29,0x47, + 0x0e, /* GL is G1 from now on */ + 0x58,0x6b, /* 馬 */ + /* ESC $ * H (shift G2 to CNS 11643 plane 2) */ + 0x1b,0x24,0x2a,0x48, + 0x1b,0x4e, /* GL is G2 for next char */ + 0x30,0x21, /* 毦 */ + 0x0f, /* GL is G0 from now on */ + }, + 0, 0, "PR lib/59019: various iconv issues ([case 10: ISO-2022-CN to UTF-8 14/6] iconv: Illegal byte sequence (85))" }, }; #define MIN(x, y) ((x) < (y) ? (x) : (y)) diff --git a/lib/libiconv_modules/ISO2022/citrus_iso2022.c b/lib/libiconv_modules/ISO2022/citrus_iso2022.c index 126d38316df4..a28dc0be0022 100644 --- a/lib/libiconv_modules/ISO2022/citrus_iso2022.c +++ b/lib/libiconv_modules/ISO2022/citrus_iso2022.c @@ -129,7 +129,7 @@ typedef struct { #define _FUNCNAME(m) _citrus_ISO2022_##m #define _ENCODING_INFO _ISO2022EncodingInfo #define _ENCODING_STATE _ISO2022State -#define _ENCODING_MB_CUR_MAX(_ei_) MB_LEN_MAX +#define _ENCODING_MB_CUR_MAX(_ei_) 10 #define _ENCODING_IS_STATE_DEPENDENT 1 #define _STATE_NEEDS_EXPLICIT_INIT(_ps_) \ (!((_ps_)->flags & _ISO2022STATE_FLAG_INITIALIZED)) @@ -1012,7 +1012,7 @@ _ISO2022_sputwchar(_ISO2022EncodingInfo * __restrict ei, wchar_t wc, { _ISO2022Charset cs; char *p; - char tmp[MB_LEN_MAX]; + char tmp[10]; size_t len; int bit8, i = 0, target; unsigned char mask; @@ -1177,7 +1177,7 @@ _citrus_ISO2022_put_state_reset(_ISO2022EncodingInfo * __restrict ei, size_t * __restrict nresult) { char *result; - char buf[MB_LEN_MAX]; + char buf[10]; size_t len; int ret; @@ -1206,7 +1206,7 @@ _citrus_ISO2022_wcrtomb_priv(_ISO2022EncodingInfo * __restrict ei, _ISO2022State * __restrict psenc, size_t * __restrict nresult) { char *result; - char buf[MB_LEN_MAX]; + char buf[10]; size_t len; int ret;