From owner-freebsd-standards@FreeBSD.ORG Sat Apr 5 20:16:17 2014 Return-Path: Delivered-To: standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 45E25658; Sat, 5 Apr 2014 20:16:17 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AB1539CC; Sat, 5 Apr 2014 20:16:16 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.8/8.14.8) with ESMTP id s35KG7Ub015242; Sat, 5 Apr 2014 23:16:07 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s35KG7Ub015242 Received: (from kostik@localhost) by tom.home (8.14.8/8.14.8/Submit) id s35KG7pf015241; Sat, 5 Apr 2014 23:16:07 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 5 Apr 2014 23:16:07 +0300 From: Konstantin Belousov To: Christian Neukirchen Subject: Re: standards/188173: O_NOFOLLOW visibility not POSIX 2008 conforming Message-ID: <20140405201607.GL21331@kib.kiev.ua> References: <201404011531.s31FVVNR008903@cgiserv.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cLlE6j+44ygFdGhU" Content-Disposition: inline In-Reply-To: <201404011531.s31FVVNR008903@cgiserv.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: standards@freebsd.org, freebsd-gnats-submit@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2014 20:16:17 -0000 --cLlE6j+44ygFdGhU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 01, 2014 at 03:31:31PM +0000, Christian Neukirchen wrote: > >Fix: > Adjust the condition in /usr/include/sys/fcntl.h to use _POSIX_C_SOURCE >= =3D 200809 >=20 > #if __BSD_VISIBLE > #define O_NOFOLLOW 0x0100 /* don't follow symlinks */ > #endif >=20 Thank you for noting this. Still, I want to formally request your confirmation that the following patch works for you. I only have 1003.1, 2013 access right now. diff --git a/sys/sys/fcntl.h b/sys/sys/fcntl.h index 3461f8b..2691449 100644 --- a/sys/sys/fcntl.h +++ b/sys/sys/fcntl.h @@ -96,7 +96,7 @@ typedef __pid_t pid_t; #define O_FSYNC 0x0080 /* synchronous writes */ #endif #define O_SYNC 0x0080 /* POSIX synonym for O_FSYNC */ -#if __BSD_VISIBLE +#if __POSIX_VISIBLE >=3D 200809 #define O_NOFOLLOW 0x0100 /* don't follow symlinks */ #endif #define O_CREAT 0x0200 /* create if nonexistent */ --cLlE6j+44ygFdGhU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTQGSGAAoJEJDCuSvBvK1BxxUQAJf9dfRzfibeNurPwjV5roDy 6btTsW+hgaAYwhOFnTDaRLcwdW0Z+R3zFZKB0T6j+VtAe2y4ekOWZYwRwoIkgLsq WzD2LFIgPT+lccZxNI+G45GHKAYREP8tte1fH6iQwoUYjw6qw1kU6pCvFmRatsUf zTO3bdqsBd8AD1m/8heHfcWnI1y+jh8o8m1vgIz9XToYczm8l9kEgcXZNS9n7fU5 wJ6vzJcPPpT+/DdpLWld6CFqM+ERE7KLOMN+WJOigGWeMTMACpvseGfiGngB1AsC wIVxYoftZBixVC3dfmt0mDFC1ljcY6JwSk7eYnqH1Z1o8YeaxKxE9V3ZiyKjBmxL wAb7H+l019or0FqqBL4a+l+Lye1rkmFbcGFl6wuionb+WCafsBQHLcnZVEB4Dgrt iEdanWEKYRRoHBzNjU7/s/s6DRp3Co5aCvsT3BPZtZnlpkRSbtcTYIaQ3QKh+i9s 5K/fqUhfLJmK/J+WCmZyeT8uforuxAj89eMUicDGU34a3klxIPKJel5sQGLYcwaW pQ2OdOlVHmhhLLt/P7k360xisytFuONakf5P6JCz5etQNi2zCuWf5g1gov/ZXFN7 UFVPAriUUGXYKs8BRxQjKCYsH0XjbDGvwv4KPBO/tNpIUcZMoj6VTdAd4OKn8fQs sR7ZcTDjeWX/eHCp6iDn =zV9O -----END PGP SIGNATURE----- --cLlE6j+44ygFdGhU--