From nobody Tue Mar 15 20:58:37 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 929D31A1EFBD for ; Tue, 15 Mar 2022 20:58:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KJ5Nf57cQz3DYQ for ; Tue, 15 Mar 2022 20:58:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-oi1-x22d.google.com with SMTP id 12so570826oix.12 for ; Tue, 15 Mar 2022 13:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6TAUaEwPbpki29SWxDLhRGsROo6K1GKvcczSVow8t/o=; b=Uu7WvnsUeLpMaj/X7rnK1s/4MsRKM/iYv2JuogOaMQb1vR388KKlkCvfcd86xbQUo9 MFdltW3t1IxtQEH62z813ZLprUR7wRilcU3tiVTEnATg0D8Pe0Kbe96TEWAkIcm3JsxE z6GZs72hQnA2/kdM7jT+iJi6FXOU+xS2ClTjEQ6VyJk7TWmKZuBGbpD8mInixjp/OdqV fdKJKvh+mmRfen2kc++TsDHNQp0AbvJR1dvhFe9xMrBhCDuNQaL6ltOtHe73IbqHFuze Ze+JSRCl6M3OUhnAHXfYWizZtWrh9g76pwbfuik/JVEm6C6aDp+GcLonhnbBJ93VAmrK 6yCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=6TAUaEwPbpki29SWxDLhRGsROo6K1GKvcczSVow8t/o=; b=Q716Tg6QnJRyQu2oE41wZQFuf3OOMpf8EhptHLNYcs1V5S4hBCDRxJNNpf6zeE96ga JxI6ZPSJrXoRRPexrst16FxLv8nhjehBzQkjMUpSWQe5RfOcEPscyxdZGxcnddzdT8/T arX0BSp0JAJjhJmRHukJab1+Xgsn6mE3AXnEvwkJTMJw3o/zD1bsHwEON4r9f9EW1msU qBIR3KuyZr30XojH01lnlcVNJKsqD97Cr4evC9MTLkRhaIEtmsVX0sOvzS5JpSFHZ5Be oLTm50J4lTkOlkFpSaaMSdBF2ZpTJIcq1EmMb3cns3Ps+Jfmn2a7G7/79YEdjQ6sl3w7 YB8Q== X-Gm-Message-State: AOAM531bAjWIHd4Av2jeDBO+/oryFglQFF5K1FCzFUjRHDlB7ZhQ2dPf Py3eiZlloKUshk2JlSj6afVw1xYmOihAqg== X-Google-Smtp-Source: ABdhPJyyTw1RLgFlvBrvl0MykdOvdKzkwtRCqZvbiO0AJa7y6N8TrsmR0J1QWc0pDK4n/xlp310DmQ== X-Received: by 2002:a05:6808:b39:b0:2d9:b551:8825 with SMTP id t25-20020a0568080b3900b002d9b5518825mr2591585oij.177.1647377921628; Tue, 15 Mar 2022 13:58:41 -0700 (PDT) Received: from framework ([187.144.106.84]) by smtp.gmail.com with ESMTPSA id w1-20020a056808090100b002da82caced5sm135191oih.3.2022.03.15.13.58.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 13:58:40 -0700 (PDT) Date: Tue, 15 Mar 2022 16:58:37 -0400 From: Mark Johnston To: freebsd-stable@freebsd.org Subject: Re: FreeBSD Errata Notice FreeBSD-EN-22:11.zfs Message-ID: References: <20220315192830.BA7F7454F@freefall.freebsd.org> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4KJ5Nf57cQz3DYQ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=Uu7WvnsU; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::22d as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[187.144.106.84:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::22d:from]; MLMMJ_DEST(0.00)[freebsd-stable]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, Mar 15, 2022 at 09:35:51PM +0100, Christoph Moench-Tegeder wrote: > ## FreeBSD Errata Notices (errata-notices@freebsd.org): > > > # fetch https://security.FreeBSD.org/patches/EN-22:11/zfs.patch > > Unless I'm totally cross-eyed, this patch is not what has been > committed to releng/13.0 > https://cgit.freebsd.org/src/commit/?h=releng/13.0&id=f5be20afc3568876c44269420a542627238e4da0 > and the committed version does not compile (just bombed out here, so, > yeah, confirmed). > To be more precise, the newly added function vn_flush_cached_data() in > sys/contrib/openzfs/include/os/freebsd/spl/sys/vnode.h is inside the > '#ifndef IN_BASE' guard in zfs.patch but outside in releng/13.0. As > it accesses vp->v_object (vp being a struct vnode *) and the #include > of sys/vnode.h is inside a '#ifndef IN_BASE' guard in both the patch > and the committed version, we don't have a full declaration of > struct vnode in the committed variant of aforementioned file, so that > vp->v_object must not be (at least as far as the C compiler is concerned). Indeed, I missed a fixup commit that should have been pushed together with the original patch: https://cgit.freebsd.org/src/commit/?id=14bf91a0431e6b410ec9cf029172dfc5a99eb58f I'll work on getting this fixed ASAP. Thank you for the report.