From nobody Wed Jul 29 13:46:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h9DBp5XcKz6nGLC for ; Wed, 29 Jul 2026 13:46:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h9DBp3zQ5z44ZY for ; Wed, 29 Jul 2026 13:46:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785332786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oyoHh/+vNFPptHNJdNX4PaLSqEcRi96sEl77QikrjyA=; b=iMGuHPq5+rKexspZ7UTbna/vhHx2momMbhHMrMPdbF0OYadG3syShglmlfFbuiDMqFiJc3 H9eQnm8kduZJv+pt+pJ3HIU7O0EeuaNqrQiKA15IehvnvOekS1gi3Wlq0gcjYmg6Vot+/z 2KRCAELjkSNZ9MqFkNRRFTxwd64u14Qqz8nBudLSfHjr3zMX4v+14q6dNx/FSPLA+1xnnw tRsQVF8jQujEBCAV3gAOVwj6toHpfBehpkx6S09g6LIGUrSAABrYCa3PsOAcbLI4z8FhAC zifQlSxyZIu+rTDiZGnb5NVDqcJbFWGHFOEYeWLbTJXUzOGRNfSrMB91VM/NIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785332786; a=rsa-sha256; cv=none; b=AQ/M+uud3exBta/G6XvzntAefoZ8c0vXsyqSZbL/4/9ddsDe+TGyletWTpjifpsssZ7l3x AkyUg8RnYUDFgPNQcBZcT6HHbPWL2F8OszN1MqmpgDmyuw2WTKMFMehGeSaCM5f4qSBXEB kOztenEqnd9gVvAJSpuRKcRuNSc5Po6sp6YQHhkQYQfmmsmGALcheu8IBcqwVWlw0CZaet Ons30aAyS6wubRCuVk0lK2Obaz9tj684XIUuRUe/qxOKTbR6uzvieJ4rZrN+HtZiu816qf /LwFHnLeFtWgZmSdvfEhh0OBMF4laKYlp41IDDCrC/DBuVkTH1GYrTnJj3YJFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785332786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oyoHh/+vNFPptHNJdNX4PaLSqEcRi96sEl77QikrjyA=; b=uG+31eZbRXzzRFRlsC+VCzVWg3pclq5f6WfSyjQbVRX+LPSyrOXCJId8WX9fn+dCUdP4/x NEV8vVsrXJJQNRFOD1NilFrAeueOqSy8QeFg1ujaao8rxmW/znsoam08LardH3MI9aj22M GTdwc8HDuTd4ZjrR+ANOLae8CG1ePFJPLYn7Fg8JARvbxAXl/VEYqtFNV1/Y1Qffut3SVj h/aIPuDLN2EHy+ObN2AVAKYUInj2mag0SdG3m8zkfmZW1y65SApgDYzp+sZWs8rkNR+ZBM 10wiFY3KlHMeMS5TNfAsvgzz4LMkb1yqagYyiurxT3zSQwChWK5gCTOsYZy96w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h9DBp2k6ZzCvY for ; Wed, 29 Jul 2026 13:46:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18293 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Jul 2026 13:46:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b6823a973737 - main - ipsec: Fix a lock leak in ipsec_chkreplay() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b6823a973737f06ea6cf0ea5a3083383af2ba5a4 Auto-Submitted: auto-generated Date: Wed, 29 Jul 2026 13:46:26 +0000 Message-Id: <6a6a0432.18293.26495842@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b6823a973737f06ea6cf0ea5a3083383af2ba5a4 commit b6823a973737f06ea6cf0ea5a3083383af2ba5a4 Author: Mark Johnston AuthorDate: 2026-07-29 13:19:08 +0000 Commit: Mark Johnston CommitDate: 2026-07-29 13:19:08 +0000 ipsec: Fix a lock leak in ipsec_chkreplay() Reported by: Chris Jarrett-Davies of the OpenAI Codex Security Team Reviewed by: pouria, kp Fixes: 0361f165f219 ("ipsec: replace SECASVAR mtx by rmlock") MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58521 --- sys/netipsec/ipsec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netipsec/ipsec.c b/sys/netipsec/ipsec.c index 92d0201b398a..12d1b7945e64 100644 --- a/sys/netipsec/ipsec.c +++ b/sys/netipsec/ipsec.c @@ -1353,8 +1353,10 @@ ipsec_chkreplay(uint32_t seq, uint32_t *seqhigh, struct secasvar *sav) * subspace. */ if (tl < window - 1 && seq >= bl) { - if (th == 0) + if (th == 0) { + SECREPLAY_UNLOCK(replay); return (0); + } *seqhigh = th - 1; seqh = th - 1; if (check_window(replay, seq)) {