Date: Fri, 18 Jun 2004 12:21:59 +0900 From: Pyun YongHyeon <yongari@kt-is.co.kr> To: Thomas Moestl <t.moestl@tu-bs.de> Cc: freebsd-sparc64@freebsd.org Subject: Re: TCP/UDP cksum offload on hme(4) Message-ID: <20040618032159.GA15377@kt-is.co.kr> In-Reply-To: <20040618012045.GF747@timesink.dyndns.org> References: <20040616034520.GB7887@kt-is.co.kr> <20040617024759.GA5610@timesink.dyndns.org> <20040617063022.GA11797@kt-is.co.kr> <20040618012045.GF747@timesink.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 18, 2004 at 03:20:45AM +0200, Thomas Moestl wrote: ... > > Just one further remark: > > > + if ((ifp->if_flags & IFF_LINK0) != 0) > > + hme_csum_features |= CSUM_UDP; > > + else > > + hme_csum_features &= ~CSUM_UDP; > > Maybe if_hwassist should be changed accordingly in this case, too. It Yes, it needs if_hwassist modification too. > might be a bit counter-intuitive to need to do an extra SIOCSIFCAP > before this takes effect. > > > Thanks for your changes! Since people have reported that this patch > works well on PCI hmes, I am planning to commit it soon. > Great! Thank you very much. Regards, Pyun YongHyeon -- Pyun YongHyeon <http://www.kr.freebsd.org/~yongari>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040618032159.GA15377>