From owner-svn-src-head@FreeBSD.ORG Mon Jul 16 08:30:04 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99F5B1065800 for ; Mon, 16 Jul 2012 08:30:04 +0000 (UTC) (envelope-from bounces+73574-9504-svn-src-head=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id 43A5E8FC17 for ; Mon, 16 Jul 2012 08:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=FaKrm5dHPpTcYGAQusunveywHxY=; b=AegcSlw0e8WS/SSh4ieJnDRlFRJy U+/aS+Vb9g3KceMOBivD6Ks5qrid4+rxKtVNuxjkWAmWqi/Zi54SV+Xpl4pQ74sv aXFVPWcmY2Ag+wZBs3EVZjMAkIlYU044wqlx9tRh6vxHk06zMOZ7ZpZxZGd4mE4j onMY7umA2DH9rrw= Received: by 10.41.149.112 with SMTP id f04-09.6680.5003D10B6 Mon, 16 Jul 2012 08:30:03 +0000 (UTC) Received: from mail.tarsnap.com (unknown [10.8.49.124]) by mi3 (SG) with ESMTP id 5003d10b.4500.11758b for ; Mon, 16 Jul 2012 03:30:03 -0500 (CST) Received: (qmail 46038 invoked from network); 16 Jul 2012 08:27:53 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 16 Jul 2012 08:27:53 -0000 Received: (qmail 73436 invoked from network); 16 Jul 2012 08:28:16 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 16 Jul 2012 08:28:16 -0000 Message-ID: <5003D0A0.3050209@freebsd.org> Date: Mon, 16 Jul 2012 01:28:16 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120627 Thunderbird/13.0.1 MIME-Version: 1.0 To: Konstantin Belousov References: <201206301636.q5UGaNCB029813@svn.freebsd.org> In-Reply-To: <201206301636.q5UGaNCB029813@svn.freebsd.org> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: EvYvoie/qnEezyq2t4eRKjDm9X7ZKbCMt75WvXA+XNFOntOwuktqNtCfBKGCD6Mz3hSN4OawXM+shwmEwWyIJB7uFHs+Q6hyO9eYUVyXYyYfGCCG450Cip7Gt7WLApr4TSwnlyYbR4POocRV4Nb5NSIDNS6jPwS6Wr/wrTifqLI= Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r237847 - head/usr.bin/killall X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2012 08:30:04 -0000 On 06/30/12 09:36, Konstantin Belousov wrote: > New Revision: 237847 > URL: http://svn.freebsd.org/changeset/base/237847 > > Log: > Once in a month, when the moon is full, killall mistakenly considers > living process as a zombie and refuses to kill it. The cause is that > the code masks ki_stat with SZOMB to compare with SZOMB, but ki_stat > is not a mask. > > Possibly reported by: cperciva For the archives: Judging by the frequency with which I was seeing killall failing to send a signal and the fact I haven't seen it happen since I applied this patch, I'm 99.9999% confident that this was indeed the bug I was running into. Hopefully everybody else is sending signals to specific pids rather than using killall during log rotation like I am. :-) -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid