From owner-svn-src-all@freebsd.org Tue Nov 28 18:02:03 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B504ADE8ED8; Tue, 28 Nov 2017 18:02:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 91B04713B8; Tue, 28 Nov 2017 18:02:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 39D8D10A8BE; Tue, 28 Nov 2017 13:01:57 -0500 (EST) From: John Baldwin To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326286 - head/sys/cddl/dev/dtrace Date: Mon, 27 Nov 2017 15:58:47 -0800 Message-ID: <1636541.esPCmqdWtd@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <20171127214140.GB75832@raichu> References: <201711271842.vARIgNCk007369@repo.freebsd.org> <2717040.9stBD4iAp4@ralph.baldwin.cx> <20171127214140.GB75832@raichu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 28 Nov 2017 13:01:57 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 18:02:03 -0000 On Monday, November 27, 2017 04:41:40 PM Mark Johnston wrote: > On Mon, Nov 27, 2017 at 11:28:07AM -0800, John Baldwin wrote: > > On Monday, November 27, 2017 06:42:23 PM Mark Johnston wrote: > > > Author: markj > > > Date: Mon Nov 27 18:42:23 2017 > > > New Revision: 326286 > > > URL: https://svnweb.freebsd.org/changeset/base/326286 > > > > > > Log: > > > Don't use pcpu_find() to determine if a CPU ID is valid. > > > > > > This addresses assertion failures after r326218. > > > > I'd perhaps rather revert the assertion as per my other mail? > > I considered waiting for a resolution of that thread, but it seems to me > that using CPU_FOREACH()/CPU_ABSENT() is more idiomatic anyway? We > already use CPU_FOREACH() in a few places in dtrace.c, and > dtrace_ioctl.c is meant to be a fork of the ioctl handler from illumos, > i.e., we shouldn't make much effort to avoid diverging from upstream. Fair enough. -- John Baldwin