From owner-cvs-all@FreeBSD.ORG Fri Jun 11 02:55:03 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EBA216A4CE; Fri, 11 Jun 2004 02:55:03 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 041F543D1F; Fri, 11 Jun 2004 02:55:01 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i5B2rsN6049246; Thu, 10 Jun 2004 22:53:54 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i5B2rrQc049243; Thu, 10 Jun 2004 22:53:53 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 10 Jun 2004 22:53:53 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20040611024817.GK78955@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 02:55:03 -0000 On Thu, 10 Jun 2004, Alfred Perlstein wrote: > * Robert Watson [040610 19:18] wrote: > > > > Agreed. If the caller doesn't mind us dropping the unp_mtx, the first > > logical thing to try is to replace unp_gcing with an sx lock (or the > > like), and only acquire unp_mtx when calling into code that needs it. > > That's not really needed. The idea is just to avoid initiating another > gc scan while one is in progress. It would almost be tempting to do that cleanup in a separate worker (perhaps a callout), and just launch the cleanup using a cv when necessary. That would get all the work out of a context that probably includes socket activity, etc. > I'll look at it if I find the time/motivation. Sounds good to me :-). I'll move ahead with merging other stack locking bits in the mean time. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research