From owner-svn-src-head@freebsd.org Thu Feb 23 01:30:03 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2452CE863C; Thu, 23 Feb 2017 01:30:03 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6ED901577; Thu, 23 Feb 2017 01:30:03 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-qk0-x233.google.com with SMTP id u188so19738976qkc.2; Wed, 22 Feb 2017 17:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GHXUb9Ha+n76F79OBinuw0Bt8ZrHU25xKHW6Xtm9nRg=; b=nlAkmwW8b/sWCHmxaDN7KQ9Q9lbMOu7xcO3Zs524dWvXD7YcQZqe7+5rhcz9UZTi84 QdJ2DaTfdpglUZjHXaYHuVkOU1lZcK4gdHiUH4tqpGwVBI9o38dyIowLbj5g3yJ++n97 QBdOlVQpfNnpHmMQi+y2GUcYl7I/+GDMnSpt4IaRFXF6UEs/oPCHHuL3sdneg5LuCzPq LsFaqT3SPJFA0ZG6ZraUzBWlOiCrP+xWlyq/aZbrnJU5iY478QakP06q1XdxscFa3okh 1e8J1H+qQtInyWvMEcaVSqGhjyOgTHWnLqZ/HmLgqNz11iHR7pJfZw9Ymk08/fESAu9d sduA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GHXUb9Ha+n76F79OBinuw0Bt8ZrHU25xKHW6Xtm9nRg=; b=CspL/yemDghz+28giF76Gq+qzkaRpK3ZZ6f3VQuPFTyImr0PYaxkQuuYgdXgLr8Zdn 341c4QxVISS48plDbAxYPS1bYXF8I+S96tsmezhk2/TK9y2sJqZmPm27TaSvUMSBJQw8 qHWBS0M6vVwbkJIuMfo+tfSZo0yPI2X9FUc7+q9N4KgBcCTS0rfjntpFd9+IQAJWCS7k k4WFsYiZtvGmnJQLMshtIqnf6GjPqE/v4KOINr/BlejnVVpYyQE8d88j8XrJCUDHHPIl ijrmnMCsUtJw+VtVEiQ0mzSZp2RXpOzySPHiBRjjAFnZjXrBAzW/TDfBfOKhbq9Evl90 EkvA== X-Gm-Message-State: AMke39lTQMLHRTk94Mw4aLMIja/otbls+5BQqCVvB1YZNDq2b0GvdcjP8Pfmfpr5PyPo92xRTkIkL/kYVo+wsw== X-Received: by 10.55.18.82 with SMTP id c79mr5048598qkh.119.1487813402524; Wed, 22 Feb 2017 17:30:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.43.120 with HTTP; Wed, 22 Feb 2017 17:30:02 -0800 (PST) In-Reply-To: <201702230118.v1N1IlwM075208@repo.freebsd.org> References: <201702230118.v1N1IlwM075208@repo.freebsd.org> From: Jonathan Looney Date: Wed, 22 Feb 2017 20:30:02 -0500 Message-ID: Subject: Re: svn commit: r314116 - head/sys/kern To: "Jonathan T. Looney" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 01:30:03 -0000 On Wed, Feb 22, 2017 at 8:18 PM, Jonathan T. Looney wrote: > Author: jtl > Date: Thu Feb 23 01:18:47 2017 > New Revision: 314116 > URL: https://svnweb.freebsd.org/changeset/base/314116 > > Log: > Fix a panic during boot caused by inadequate locking of some vt(4) driver > data structures. > > vt_change_font() calls vtbuf_grow() to change some vt driver data > structures. It uses TF_MUTE to prevent the console from trying to use > those > data structures while it changes them. > > During the early stage of the boot process, the vt driver's tc_done > routine > uses those data structures; however, it is currently called outside the > TF_MUTE check. > > Move the tc_done routine inside the locked TF_MUTE check. > > PR: 217282 > Reviewed by: ed, ray > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D9709 Sorry, this should also say: MFC after: 2 weeks The change should go back to stable/11, since EARLY_AP_STARTUP is an option there. (It appears EARLY_AP_STARTUP is a prerequisite for hitting this bug.) Jonathan