Date: Fri, 24 Jun 2011 17:30:20 GMT From: Warner Losh <imp@bsdimp.com> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/157903: automated kldload for USB class devices Message-ID: <201106241730.p5OHUKcZ040747@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/157903; it has been noted by GNATS. From: Warner Losh <imp@bsdimp.com> To: Hans Petter Selasky <hselasky@c2i.net> Cc: Robert Millan <rmh@debian.org>, freebsd-hackers@FreeBSD.org, freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-usb@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: misc/157903: automated kldload for USB class devices Date: Fri, 24 Jun 2011 11:21:05 -0600 On Jun 24, 2011, at 7:11 AM, Hans Petter Selasky wrote: > On Friday 24 June 2011 14:59:37 Robert Millan wrote: >> 2011/6/24 Hans Petter Selasky <hselasky@c2i.net>: >>>> Very nice. But why not use variable names instead of hardcoding >>>> numbers? It makes the output much easier to understand. >>>=20 >>> To save memory. >>=20 >> I haven't inspected devd code, but I was under the assumption that >> variables only lived untill resolved. What would be the point of = keeping >> them in memory after devd has finished parsing the config files? >=20 > Hi, >=20 > I haven't checked that, though if you want the readable version, then = you need=20 > to check the source code. >=20 > However I could add some code to print a vendor ID comment, based on = usbdevs. devd keeps them in memory and expands them when the commands are = executed. It will use more memory and be slower if you have lots of = variables. Now much more memory and how much slower? I kinda doubt = you'd notice on modern gear. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106241730.p5OHUKcZ040747>