From owner-svn-src-head@freebsd.org Sun Mar 25 17:44:40 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17ACBF5D244 for ; Sun, 25 Mar 2018 17:44:40 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic303-17.consmr.mail.bf2.yahoo.com (sonic303-17.consmr.mail.bf2.yahoo.com [74.6.131.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AEC087023A for ; Sun, 25 Mar 2018 17:44:39 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1521999879; bh=Xatf63oPMOQtxJrubAJzxRNGY6LYcJn7ck/vyzBqaYI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=XZ29d/RQGDw/ZN0hqVStDC28oHKYXWWRWS8f6pO4jfTLvBXgj7eFOWiTxjznUlLYo36qmT9aE4h1vD3cD5V127AEVd0jCWyhSoda7VB1hkilwZ6I16XGJKnJaeVEZlI68jMMIqR56iKjQpcRk++RIYfmYaiWia+VrAIo8E2E0AqgJbVubnN4Lz9e7IWeBcj5BIhnyo8mEXP9eBc4bERCkHefPKWJVPtGiGIO3/80Hido2qaNjJKE1wBCO72MKQAP6UZv+EyZWii2XXTia2pbVXVVWCpBbdDUVv0rvypZWOu05WZVJu7UZ5rlirLEBSWQ9WBOebXIbQrsiTC4IGrzEg== X-YMail-OSG: _gSw5MEVM1kQ7yI64FBVsLiWFUcNiKDJHZtlLBQ_Z9FN0.M9N0eR0gfiBkx9PUm NHA9s7uano3ts9fpgDcCQied0mDAVkiXTJJEZfs3tC790JTDFxK4s2.bwTFVK6f.aujkRRZ9mOf9 ysHiu4r2RE58NqigMOYZ8b1BewjFat6hXUE4RIc.uit3YmdxJ.bTZLtdHlKRVhA20qgy1XWyjw_G XY146P5fZEVHMZrwlqL6dFpaTGyPfYS6du3ZPcWxURC53lOGMeiT8rbyrvTHJb_3K8BJvgY_uF_9 gq2ydq6_mUulehWD4Vfdnl09oR4Br0me8PCJmUHgUK5qB8TR_OEjoD9aLg2Q.oRlHNz1KXPMGhbv LvRKepjWDW1pZ_3mThvKV5L0N9qmJIK2aXyq_AfyhkVEZaJ_BbWvaX8Iu5WGtmuYKsjz2eoOfu1o geD7NxFgcbfAAQ0MdizhOE3jU2AbXTPrMVK1DmwnqrUuuuJ7lfb3lDBavnuT6AHvnMoT4e5dAzDa UDNf.XJLmKg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.bf2.yahoo.com with HTTP; Sun, 25 Mar 2018 17:44:39 +0000 Received: from 181.52.72.201 (EHLO [192.168.0.5]) ([181.52.72.201]) by smtp418.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b8bd6c2cb4c8fc06ea5f9493f5a94354; Sun, 25 Mar 2018 17:34:30 +0000 (UTC) Subject: Re: svn commit: r331510 - in head: share/man/man4 sys/conf sys/dev/vmware/vmci sys/modules/vmware sys/modules/vmware/vmci To: rgrimes@freebsd.org Cc: Mark Peek , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201803251603.w2PG3KLQ041797@pdx.rh.CN85.dnsmgr.net> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <3abca0b5-8820-b937-d468-1021e3b7bbe6@FreeBSD.org> Date: Sun, 25 Mar 2018 12:34:28 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201803251603.w2PG3KLQ041797@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 17:44:40 -0000 On 25/03/2018 11:03, Rodney W. Grimes wrote: >> >> On 25/03/2018 06:49, Rodney W. Grimes wrote: >>>> On Sat, Mar 24, 2018 at 6:27 PM, Rodney W. Grimes < >>>> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >>>> >>>>>> Author: mp >>>>>> Date: Sun Mar 25 00:57:00 2018 >>>>>> New Revision: 331510 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/331510 >>>>> These files do not each contain a usable copyright, though >>>>> they seem to contain SPDX tags that indiate they should contain >>>>> a BSD 2 clause copyright. >>>> IANAL but I believe you meant "...they should contain a BSD 2 clause >>>> *license*". The files should contain a valid copyright. >>> A valid, but unusable. As the copyright is it is a full copyright >>> held by vmware without any rights to be published or redistributed >>> any any manner by anyone but vmware. >>> >>> "Copyright (c) 2018 VMware, Inc. All Rights Reserved." >>> >>> That is a restrictive copyright, allowing no one to publish, or >>> in our case, redistribute, without a further license of some form. >>> >>>> The intent of my commit and the author were to use the implied SPDX version >>>> of the licenses without burdening the source code with the more heavyweight >>>> license text. Having seen SPDX in the src tree, I believed >>>> the SPDX-License-Identifier was sufficient. But, to your point, I'm not >>>> sure I have seen a discussion or a decision on it. >>> SPDX tags are purely to be treated as "advisory" and in no one imply >>> or create any license agreement. >> As happens in economics, different lawyers can have different >> interpretations. Our practices were consulted with the SPDX guys but >> other projects have different practices. >> >> While the sound practice, especially when you don't own the code, is to >> add the SPDX tag in addition to the license text, the linux developers >> are encouraging replacing it altogether with the SPDX tag. In their case >> they keep a reference to the complete license text elsewhere and they >> have some repository log where the copyright owner did the change. > They have grown use to this from the way the GPL is handled, since > the length of the body of that license would be impractical to > include. > >> For contrib code we just follow upstream. In no case can anyone other >> than the copyright owner clarify, or otherwise change, a license. > That does bring a question of why this code is not either on > a vendor import branch, or in contrib? > > Can you point to any files in /usr/src that lack a full and complete > standalone license? Sans perhaps some GPL code that has a pointer > to COPYING and files that can not such as Makefile and .mk's. There are some. Here is an outstanding example: usr.sbin/bhyve/bhyvegc.c FWIW, the one time I did a change I added a copyright disclaimer to the commit log  to avoid future issues: https://svnweb.freebsd.org/base?view=revision&revision=318788 Cheers, Pedro.