From owner-freebsd-audit Sun Nov 19 6: 5:55 2000 Delivered-To: freebsd-audit@freebsd.org Received: from mail.utfors.se (mail.utfors.se [195.58.103.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FE1537B479; Sun, 19 Nov 2000 06:05:53 -0800 (PST) Received: from ludd.luth.se (md4692003.utfors.se [212.105.32.3]) by mail.utfors.se (8.8.8/8.8.8) with ESMTP id PAA26048; Sun, 19 Nov 2000 15:05:50 +0100 (MET) Message-ID: <3A17DE2E.92A92EC2@ludd.luth.se> Date: Sun, 19 Nov 2000 15:05:34 +0100 From: Joachim =?iso-8859-1?Q?Str=F6mbergson?= Organization: Acne X-Mailer: Mozilla 4.75 [en] (X11; U; FreeBSD 4.1-STABLE i386) X-Accept-Language: en-US MIME-Version: 1.0 To: Kris Kennaway Cc: audit@FreeBSD.ORG Subject: Re: bootpd patch References: <20001119032345.A91835@citusc17.usc.edu> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi! Kris Kennaway wrote: > The following patches are taken from OpenBSD. Reviews, anyone? Took a few minutes to check the diffs. Didn't find antything that made me jump. I.e. it looked to me like you correctly fixed several buffer problems, unsafe calls and one nice misspelling. But I'm not an expert, so since the devils are in the details, I may have missed some bug that really hides behind the characters. -- Cheers! Joachim - Alltid i harmonisk svängning --- FairLight ------ FairLight ------ FairLight ------ FairLight --- Joachim Strömbergson ASIC SoC designer, nice to CUTE animals Phone: +46(0)31 - 27 98 47 Web: http://www.ludd.luth.se/~watchman --------------- Spamfodder: regeringen@regeringen.se --------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message