From owner-svn-ports-all@freebsd.org Wed Feb 20 07:09:53 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EB5A14E8B9A; Wed, 20 Feb 2019 07:09:53 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DF9369CF0; Wed, 20 Feb 2019 07:09:53 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x52c.google.com with SMTP id q206so11406721pgq.4; Tue, 19 Feb 2019 23:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PxTl66aYm/HvJIwpBi2OYgQiwr/lA0KE1Q+dGE2l2dY=; b=HM9xrGignr4iYToKbdULeBLDjufooDzYlZ8+iNt9WxzbPQKLMFFmXLTmHaUd9UXa9L t0ZXkk3Ux3KWwcTYpXJQZ4YUz8sXJYB3JpKSn26iRGTZlYNS9suwajzibYzTNCRhdq7c y1KgLFu6vdZHDsU7aYMZZwEnqFA9+VRzylyVdpXTODChMfjukN3z4vNTvxfhaE1et3zs HHSPeMYO6VACCVv4ciVDIMvouXmPeZuce4Yuel7YwUPvuY10h0f2ozM3dNDy1+rGFRT1 tCzr/VEMaWcJaG30NSjSlEiyixyoIwdB5O6OPnjkRxfxMt8v6bBMiWDVgRwOke3QYh1K X9/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=PxTl66aYm/HvJIwpBi2OYgQiwr/lA0KE1Q+dGE2l2dY=; b=bXsSniO111v9bcXP9B+5jrkynDWgbN6HatGeIDi3mQdfllo92nH0PLwPFQAEcvjVB8 9/0xpuzGn7LUCfW19XHyDcSYeEbdqFLk7VYX9AQNpmFO5HJ+WuaEB5uIvqD6TDzEkNi4 V4SHvMJ/m5+PH8+ZaNQ+RtpiRD1RV6e+caYsVzJHQpvpCG28bp7CEfAMrYQApvWYGwNX v4IHiwvVPdNDLgkcMXJIKv4BWiLDaXP6l1QhhJSHCq+w1Qmown9HpcUfpM9IZIe+GLW3 PJC/vZepacoMVwKXHQ//vWxoy5Y4TW21EMlfJTN5amBFBLpYsiJNrA0HF3VYL5HXT+Eh MN9g== X-Gm-Message-State: AHQUAua86ruAeiz8UXCxPdM0IFY1ChB3BX189Izl5GwCdwm8hQ24YXAI b2vIjBqzxkuqcMr3MynqzwVOVG5C X-Google-Smtp-Source: AHgI3IZ9x+iCOAEb+RdIldMiRiqw/JvehkENsTbjB74G14pmmA053IzY/2UKO9i2HdfWaOlQOKwX4g== X-Received: by 2002:a62:20c9:: with SMTP id m70mr32318263pfj.118.1550646591487; Tue, 19 Feb 2019 23:09:51 -0800 (PST) Received: from [192.168.1.105] (119-18-15-55.77120f.syd.nbn.aussiebb.net. [119.18.15.55]) by smtp.gmail.com with ESMTPSA id d88sm30408924pfe.19.2019.02.19.23.09.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 23:09:51 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r493407 - head/graphics/xpdf4 To: Tobias Kortkamp Cc: Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joe Marcus Clarke References: <201902200614.x1K6Ev15089326@repo.freebsd.org> <20190220063422.GA18880@urd.tobik.me> <4a641dc1-0337-00ee-55a2-80cb56263c27@FreeBSD.org> <20190220065247.GA77183@urd.tobik.me> From: Kubilay Kocak Message-ID: <9efefcd1-2d46-3023-30a6-2d1a165ed149@FreeBSD.org> Date: Wed, 20 Feb 2019 18:09:47 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Thunderbird/66.0 MIME-Version: 1.0 In-Reply-To: <20190220065247.GA77183@urd.tobik.me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1DF9369CF0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 07:09:53 -0000 On 20/02/2019 5:52 pm, Tobias Kortkamp wrote: > On Wed, Feb 20, 2019 at 05:37:58PM +1100, Kubilay Kocak wrote: >> On 20/02/2019 5:34 pm, Tobias Kortkamp wrote: >>> On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote: >>>> Author: cy >>>> Date: Wed Feb 20 06:14:57 2019 >>>> New Revision: 493407 >>>> URL: https://svnweb.freebsd.org/changeset/ports/493407 >>>> >>>> Log: >>>> Remove whitespace in USE_QT, otherwise qmake_build is ignored. >>>> >>>> Reported by: Paul Beard >>>> >>>> Modified: >>>> head/graphics/xpdf4/Makefile >>>> >>>> Modified: head/graphics/xpdf4/Makefile >>>> ============================================================================== >>>> --- head/graphics/xpdf4/Makefile Wed Feb 20 04:50:53 2019 (r493406) >>>> +++ head/graphics/xpdf4/Makefile Wed Feb 20 06:14:57 2019 (r493407) >>>> @@ -27,8 +27,7 @@ SUB_FILES= xpdf-man.conf >>>> >>>> USES= compiler:c++11-lang cmake localbase:ldflags \ >>>> desktop-file-utils qt:5 >>>> -USE_QT= buildtools_build,concurrent,core,gui,network,printsupport,\ >>>> - qmake_build,svg,widgets >>>> +USE_QT= buildtools_build,concurrent,core,gui,network,printsupport,qmake_build,svg,widgets >>> >>> Next step: Replace the , with spaces to actually add Qt dependencies >>> to the port. Check with build-depends-list, run-depends-list, >>> stage-qa. Currently the port has no Qt 5 dependencies and it fails >>> to build in Poudriere: >>> >>> ===> Checking for items in pkg-plist which are not in STAGEDIR >>> Error: Missing: libexec/xpdf/xpdf >>> Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz >>> ===> Error: Plist issues found. >>> >> >> If USE_* values are never comma-separated (always space separated), >> sounds like a good portlint check to have. > > Wouldn't it be much nicer if the framework would consistently check > them on its own and refuse to proceed with the build if there are > unknown components in a USE_*? * > null, i just suggested the first thing that came to mind :) >> If we have some comma-separated support framework bits (I didn't check), >> maybe we should standardize on not doing so > > USES=qt already complains about components that it does not recognize. > I'm surprised that it accepts a comma-separated list silently. >