From nobody Thu Dec 19 03:15:58 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YDG0N4zjrz5hQcG; Thu, 19 Dec 2024 03:16:04 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YDG0N4JTTz4YGg; Thu, 19 Dec 2024 03:16:04 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734578164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JAUplQ9FgS3j6FA5EZ9pE7Y0c4BFbVSVF2pi8wRgwvw=; b=dc2qS2Z6Wm4GjNdEekMyhdwq8nmmjcQn649pp4suNeDL/d8w4CpDX2PewOozMSbzEVZEVN 5qkQz/UMeU7ukPBKL62rCo7SytwQtBBcIUDs2Bdg0q7FkrstHqlpcGmX9SCwPE+y6IJLra hJ0JXUdxE3WT2wnyK1IMBbABW2CxjGB/C1xANcETsRB3cMCqI6woyQsiKixrCAIuJ3I8pl FWmkK+nGgKFMmY0WVERWH3mx2dg6kDMj6viUacaZGYeSNDlN6ZND7bA/oyJy9XDb7+UicZ yzvD6J2t9LGavWn5VsAQQjerGTZf2+Tn8oZzvbBmKoNHlOQcLXZrXYSEcT1qxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734578164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JAUplQ9FgS3j6FA5EZ9pE7Y0c4BFbVSVF2pi8wRgwvw=; b=ebxBS6moXqI8802llpvy+Gd2qlBggFs6Mlg7rWpnTr2KvXRyIxEbYoH8qav90MBPiZUUAz vRz09xqx0IrB168dVyp4Mp0sNgT7GXa89PZrmLRG7xI1C+1PqGb6pgbNQlJqpwZCVIFI4m eGZr7oRQ9rYuOzsnyFybu8poRySBT2ljufVpNVhHUxMfiBLGiCAnUpBZzM2KROVPDbILde l5pVes0S7I6Wjhb5cXJ4rP8jCrpdU911h9XQttnBu91y3h1S/c2JhjHRHu07ZD7v8jv1KW 1BxtMZnOpDkrOgw2J28YURslyL8+XYEsFrlOnSdHk91qRmV8VStn9j+X+0BRKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734578164; a=rsa-sha256; cv=none; b=Qeqhw1+kZL0F5z+rRiYxbnvR9BJkOSosv7yjp/dXTC0NSdtDLwcwRCuullqU/njWUhUbnk 2YMa1v1H67gQ1nUAilXROBPA9qVD9fvaDgDwyzogsGQypHKcvAFOnby9YdHY/A3avnImFp LpeyaB5ZNTawLUa3oKzoqd81ww42fhLGDnrCU/o3IVe/6ZU7QnfxT6zldTrNoPaDPj1IbT oJXGqMqM3THFGXYkbn9xhFOQOxGePxRbs8f9B5MHxnQPKUIwl0rIFZAG29tC3JG8jMkZh1 BfAakC15Z5xM3jdcpWqSvUpqpGbzYX7VXv0TzvXOq+FROiiubDSxoU3kltKULA== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YDG0L2qVnzGrC; Thu, 19 Dec 2024 03:16:02 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: a1097094c4c5 - main - newvers: Set explicit git revision length From: Zhenlei Huang In-Reply-To: Date: Thu, 19 Dec 2024 11:15:58 +0800 Cc: Gleb Smirnoff , John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <2FBF4C12-1A98-4404-92A8-4B7AA3520662@FreeBSD.org> References: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Dec 19, 2024, at 5:21 AM, Ed Maste wrote: >=20 > On Wed, 18 Dec 2024 at 12:12, Gleb Smirnoff = wrote: >>=20 >> E> The status quo of --short=3D12 should be fine for quite some time. >>=20 >> AFAIU John's concern is that you can't guarantee a reproducible build = from a >> "dirty" repository. A repository that has more branches than just = the official >> ones. I just make a quick check on Netflix repo, that has both the = current >> FreeBSD history and the before-the-official-git history together, as = well as >> splitted ports subdirectories and of course our own stuff. For short = hashes >> there are roughly 2x more ambiguities than for a "clean" repo. = Apparently >> chance of collision on a long hash is also doubled. >=20 > I suspect the six or seven character hashes I listed are still unique > in your repository. If not, adding one more character to get to seven > or eight will be enough. Pick a release and give `git rev-parse > --verify --short=3D1 ` a try in your repo -- I'm sure you'll get = a > unique short hash that's still much shorter than 12 characters. Just a reminder, we also have git_cnt, so even a combination of non-uniq short git hash and `git_cnt` is still sufficient to spot which version = was built from. So I do not think we need pay much concern with this, unless we drop = `git_cnt`. Best regards, Zhenlei