From owner-freebsd-emulation@FreeBSD.ORG Sun Apr 13 19:12:03 2008 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E09661065671 for ; Sun, 13 Apr 2008 19:12:03 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id 5FAB28FC0C for ; Sun, 13 Apr 2008 19:12:03 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so1419300fgg.35 for ; Sun, 13 Apr 2008 12:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type:from; bh=J+/OZLHg9Y3eEPkTisdLlMj+6KnTYHqzsXwb0CkzcRI=; b=jxE8opFQ/FPLvtOYA+WkSvc2K/FTTmIn3cPvyioqyIJvlEKoa6oCNh2ZtZVqVq/SXWQWpd8OxclKwqwPC8AMmXu0kEDOxMrDjxBXavdYFuyiKE8Mjbm/MAbnM6j1DF26Xn9Dr6wTWqsLacKbpJw/vyoNol4X9j+FLRSAyWLnLEo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type:from; b=PHo8+Tni47jLvnJ1ygjyhWHC7+EBU3853AnCVp7mnVunSjdkTzlL1y3ao5VEce8aSe3/5RtfIpauh1tDUfpjs2TgJoJUtUHhDE6yqA9IxLr/AA6beobs8Igtu+ndvoPl33sZkdAge64EIaLWNBS3AQWQjNqgbzHoqeOR+Kv5Fxs= Received: by 10.86.4.2 with SMTP id 2mr6279721fgd.27.1208113921814; Sun, 13 Apr 2008 12:12:01 -0700 (PDT) Received: from ora.chd.net ( [81.200.6.196]) by mx.google.com with ESMTPS id 4sm4099381fgg.4.2008.04.13.12.11.59 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 13 Apr 2008 12:12:00 -0700 (PDT) Date: Sun, 13 Apr 2008 23:11:55 +0400 (MSD) To: Kostik Belousov In-Reply-To: <20080413183659.GA18958@deviant.kiev.zoral.com.ua> Message-ID: <20080413231135.K1079@ora.chd.net> References: <20080412181712.Y38920@ora.chd.net> <20080412145401.GA4139@freebsd.org> <20080413214624.S7426@ora.chd.net> <20080413183248.GA68642@freebsd.org> <20080413183659.GA18958@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed From: Chagin Dmitry Cc: freebsd-emulation@freebsd.org, bsam@freebsd.org, Chagin Dmitry Subject: Re: Call for review && test: linux_kdump-1.6 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 19:12:04 -0000 On Sun, 13 Apr 2008, Kostik Belousov wrote: > On Sun, Apr 13, 2008 at 08:32:48PM +0200, Roman Divacky wrote: >> On Sun, Apr 13, 2008 at 09:58:08PM +0400, Chagin Dmitry wrote: >>> On Sat, 12 Apr 2008, Roman Divacky wrote: >>> >>>>> And question: whether i can add to linuxolator some ktr_struct >>>>> functionality? >>>> >>>> sure... please provide a patch and I'll take care about it. >>> >>> ok, thnx :) >>> what about EJUSTRETURN? >>> i attached simple patch for demo only (not tested). >> >> uh... can you provide diff -u ? I dont understand the diff at all ;) > > Also, please note that the ML software strips your attachments. Either > inline the patch, or use the plain-text content-type for it. > ups... ah google )) i have understood, sorry and thnx. Speech about that in linux_kdump it is impossible to distinguish EJUSTRETURN from a real error. look: --- sys/i386/i386/trap.c.orig 2008-04-13 21:39:18.000000000 +0400 +++ sys/i386/i386/trap.c 2008-04-13 22:35:25.000000000 +0400 @@ -1091,8 +1091,12 @@ td->td_proc->p_pid, td->td_name, code); #ifdef KTRACE - if (KTRPOINT(td, KTR_SYSRET)) - ktrsysret(code, error, td->td_retval[0]); + if (KTRPOINT(td, KTR_SYSRET)) { + if (error == EJUSTRETURN) + ktrsysret(code, 0, td->td_retval[0]); + else + ktrsysret(code, error, td->td_retval[0]); + } #endif /* @@ -1104,4 +1108,3 @@ PTRACESTOP_SC(p, td, S_PT_SCX); } - -- Have fun! chd