Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Oct 2017 05:36:39 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r324902 - projects/runtime-coverage/share/mk
Message-ID:  <201710230536.v9N5adlM070625@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Mon Oct 23 05:36:39 2017
New Revision: 324902
URL: https://svnweb.freebsd.org/changeset/base/324902

Log:
  Let's just nip gcc 4.2.1 in the bud and say MK_COVERAGE=no
  
  Reasoning: gcc 4.2.1 lacks -fprofile-dir support

Modified:
  projects/runtime-coverage/share/mk/src.opts.mk

Modified: projects/runtime-coverage/share/mk/src.opts.mk
==============================================================================
--- projects/runtime-coverage/share/mk/src.opts.mk	Mon Oct 23 05:26:21 2017	(r324901)
+++ projects/runtime-coverage/share/mk/src.opts.mk	Mon Oct 23 05:36:39 2017	(r324902)
@@ -468,7 +468,12 @@ MK_${var}_SUPPORT:= yes
 MK_LLDB:=	no
 .endif
 
-.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 40800
+.if ${COMPILER_TYPE} == "gcc"
+.if ${COMPILER_VERSION} == 40201
+# gcc 4.2.1 (base) is a dead end. It lacks some niceties that would cleaning
+# integrate the output with the design of MK_COVERAGE, e.g., -fprofile-dir .
+MK_COVERAGE:=no
+.elif ${COMPILER_VERSION} >= 40800
 # gcc 4.8 and newer supports libc++, so suppress gnuc++ in that case.
 # while in theory we could build it with that, we don't want to do
 # that since it creates too much confusion for too little gain.
@@ -477,6 +482,7 @@ MK_LLDB:=	no
 #      and to support 'make delete-old' when supplying an external toolchain.
 MK_GNUCXX:=no
 MK_GCC:=no
+.endif
 .endif
 
 .endif #  !target(__<src.opts.mk>__)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710230536.v9N5adlM070625>